You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/28 02:05:47 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #673: ORC-776: Include source jars during publishing snapshot
dongjoon-hyun opened a new pull request #673:
URL: https://github.com/apache/orc/pull/673
### What changes were proposed in this pull request?
This PR aims to include `source` jars at snapshots.
- https://repository.apache.org/content/repositories/snapshots/org/apache/orc/orc-core/
### Why are the changes needed?
Currently, snapshot artifacts doesn't have source jars while the release artifacts have them.
`source` jars are crucial during debugging with snapshot jars.
### How was this patch tested?
Manually.
**AFTER**
```
$ mvn install -DskipTests
$ ls -al ~/.m2/repository/org/apache/orc/orc-core/1.7.0-SNAPSHOT
total 6872
drwxr-xr-x 9 dongjoon staff 288 Mar 27 19:00 .
drwxr-xr-x 4 dongjoon staff 128 Mar 27 19:00 ..
-rw-r--r-- 1 dongjoon staff 318 Mar 27 19:00 _remote.repositories
-rw-r--r-- 1 dongjoon staff 1327 Mar 27 19:00 maven-metadata-local.xml
-rw-r--r-- 1 dongjoon staff 1808265 Mar 27 19:00 orc-core-1.7.0-SNAPSHOT-nohive.jar
-rw-r--r-- 1 dongjoon staff 443706 Mar 27 19:00 orc-core-1.7.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 dongjoon staff 210828 Mar 27 19:00 orc-core-1.7.0-SNAPSHOT-test-sources.jar
-rw-r--r-- 1 dongjoon staff 1029565 Mar 27 19:00 orc-core-1.7.0-SNAPSHOT.jar
-rw-r--r-- 1 dongjoon staff 5210 Mar 25 22:49 orc-core-1.7.0-SNAPSHOT.pom
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #673: ORC-776: Include source jars during publishing snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #673:
URL: https://github.com/apache/orc/pull/673#issuecomment-809059659
Thank you so much, @wgtmac !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #673: ORC-776: Include source jars during publishing snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #673:
URL: https://github.com/apache/orc/pull/673#issuecomment-808935586
Could you review this, @wgtmac ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #673: ORC-776: Include source jars during publishing snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #673:
URL: https://github.com/apache/orc/pull/673#issuecomment-815129482
So far, the result looks good at 1.7.0-SNAPSHOT. So, I backported this to branch-1.6/1.5.
- https://repository.apache.org/content/repositories/snapshots/org/apache/orc/orc-core/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #673: ORC-776: Include source jars during publishing snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #673:
URL: https://github.com/apache/orc/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #673: ORC-776: Include source jars during publishing snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #673:
URL: https://github.com/apache/orc/pull/673#issuecomment-808832397
Hi, @pgaref and @omalley .
Could you review this please when you have some time?
During the official release cycle, we are using the maven-source-jar plugin in Apache pom file. So, we don't need this. However, for snapshot publishing, we need this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org