You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2023/02/22 00:06:04 UTC

[GitHub] [airflow] bugraoz93 opened a new pull request, #29681: Fix Extension of Internal API Configuration Path in init_views.py

bugraoz93 opened a new pull request, #29681:
URL: https://github.com/apache/airflow/pull/29681

   It is just a tiny extension change for the configuration path.
   
   **Context:**
   While working on [BaseJob.heartbeat to InternalAPI#29315](https://github.com/apache/airflow/issues/29315), I realised that the `Webserver` wasn't taking the configuration correctly for the Internal API. This was preventing the `Webserver` from booting up due to `FileNotFoundError` when trying to run with `[webserver] run_internal_api = True`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis commented on pull request #29681: Small Extension Fix of Internal API Configuration Path in init_views.py

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29681:
URL: https://github.com/apache/airflow/pull/29681#issuecomment-1439266217

   Is this fix also solve https://github.com/apache/airflow/issues/29679?
   
   
   [Tests / Quarantined tests](https://github.com/apache/airflow/actions/runs/4237992453/jobs/7364657398#step:5:640) 
   ```console
     ============================= test session starts ==============================
     platform linux -- Python 3.7.16, pytest-7.2.1, pluggy-1.0.0
     rootdir: /opt/airflow, configfile: pytest.ini
     plugins: rerunfailures-11.1.1, anyio-3.6.2, timeouts-1.2.1, capture-warnings-0.0.4, cov-4.0.0, xdist-3.2.0, asyncio-0.20.3, instafail-0.4.2, httpx-0.21.3, requests-mock-1.10.0, time-machine-2.9.0
     asyncio: mode=strict
     setup timeout: 60.0s, execution timeout: 60.0s, teardown timeout: 60.0s
     collected 14730 items / 14729 deselected / 1 skipped / 1 selected
     
     tests/cli/commands/test_internal_api_command.py .                        [100%]
     
     -------- generated xml file: /files/test_result-Quarantined-sqlite.xml ---------
     ============================ slowest 100 durations =============================
     10.11s call     tests/cli/commands/test_internal_api_command.py::TestCliInternalAPi::test_cli_internal_api_background
     6.04s setup    tests/cli/commands/test_internal_api_command.py::TestCliInternalAPi::test_cli_internal_api_background
     0.05s teardown tests/cli/commands/test_internal_api_command.py::TestCliInternalAPi::test_cli_internal_api_background
     === 1 passed, 1 skipped, 14729 deselected, 68 warnings in 131.00s (0:02:10) ====
     Number of warnings: 0 /files/warnings-Quarantined-sqlite.txt
     All tests successful
     No stopped containers
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis merged pull request #29681: Small Extension Fix of Internal API Configuration Path in init_views.py

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #29681:
URL: https://github.com/apache/airflow/pull/29681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org