You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/15 18:15:50 UTC

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #11003: [VirtualMachine] Zero copy in set_input when input is DLTensor

AndrewZhaoLuo commented on PR #11003:
URL: https://github.com/apache/tvm/pull/11003#issuecomment-1100273385

   > Hello @AndrewZhaoLuo! As you can see my note to the PR I said about the same, but currently `set_input` method of VirtualMachine already does zero copy for NDArray input. It means that if I add `set_input_zero_copy` I should change `set_input` to method which always copies external input to internal one (and performance for people who used it in their code is reduced). No problem, I can do it for me it is more reasonable approach. What do you think @jwfromm?
   
   After talking to MBS, your change does in fact match the intended semantics better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org