[GitHub] [incubator-superset] DiggidyDave commented on a change in pull request #7319: Cache invalidation

[GitBox <gi...@apache.org>]

DiggidyDave commented on a change in pull request #7319: Cache invalidation
URL: https://github.com/apache/incubator-superset/pull/7319#discussion_r277035022
 
 

 ##########
 File path: superset/assets/src/chart/chartAction.js
 ##########
 @@ -239,6 +239,25 @@ export function exploreJSON(formData, force = false, timeout = 60, key, method)
 
     const annotationLayers = formData.annotation_layers || [];
 
+    // clear cache on POST; this happens in Explore view when "Run Query" is
+    // clicked, or in the dashboard when force refresh is clicked
+    if (method === 'POST' && 'caches' in self) {
+      caches.open(CACHE_KEY).then(supersetCache =>
+        supersetCache
+          .keys()
 
 Review comment:
   what exactly is in `keys` here? this is one req per key?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org