You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org> on 2018/05/10 22:04:08 UTC

Review Request 67074: HIVE-19493 : VectorUDFDateDiffColCol copySelected does not handle nulls correctly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67074/
-----------------------------------------------------------

Review request for hive and Matt McCline.


Bugs: HIVE-19493
    https://issues.apache.org/jira/browse/HIVE-19493


Repository: hive-git


Description
-------

HIVE-19493 : VectorUDFDateDiffColCol copySelected does not handle nulls correctly


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateDiffColCol.java 84ee94432b48b4e9fdec39e72b90809cfe67a950 


Diff: https://reviews.apache.org/r/67074/diff/1/


Testing
-------


Thanks,

Vihang Karajgaonkar


Re: Review Request 67074: HIVE-19493 : VectorUDFDateDiffColCol copySelected does not handle nulls correctly

Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67074/
-----------------------------------------------------------

(Updated May 11, 2018, 12:05 a.m.)


Review request for hive and Matt McCline.


Changes
-------

added review comment from Matt


Bugs: HIVE-19493
    https://issues.apache.org/jira/browse/HIVE-19493


Repository: hive-git


Description
-------

HIVE-19493 : VectorUDFDateDiffColCol copySelected does not handle nulls correctly


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDateDiffColCol.java 84ee94432b48b4e9fdec39e72b90809cfe67a950 


Diff: https://reviews.apache.org/r/67074/diff/2/

Changes: https://reviews.apache.org/r/67074/diff/1-2/


Testing
-------


Thanks,

Vihang Karajgaonkar