[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on a change in pull request #37: YUNIKORN-488: update protobuf and protoc versions

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #37:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/37#discussion_r637849039



##########
File path: go.mod
##########
@@ -22,7 +22,7 @@ module github.com/apache/incubator-yunikorn-scheduler-interface
 go 1.12
 
 require (
-	github.com/golang/protobuf v1.3.2
+	google.golang.org/protobuf v1.20.0

Review comment:
       I think we need to move to a far newer version than 1.20. v1.26.0 or later if available would be a good step.

##########
File path: go.sum
##########
@@ -12,8 +12,15 @@ github.com/golang/protobuf v1.3.1 h1:YF8+flBXS5eO826T4nzqPrxfhQThhXl0YzfuUPu4SBg
 github.com/golang/protobuf v1.3.1/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
 github.com/golang/protobuf v1.3.2 h1:6nsPYzhq5kReh6QImI3k5qWzO4PEbvbIW2cwSfR/6xs=
 github.com/golang/protobuf v1.3.2/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
+github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8=
+github.com/golang/protobuf v1.4.0-rc.1.0.20200221234624-67d41d38c208/go.mod h1:xKAWHe0F5eneWXFV3EuXVDTCmh+JuBKY0li0aMyXATA=

Review comment:
       We should not use a rc version for `github.com/golang/protobuf`. When we move to a later version `google.golang.org/protobuf` that should be fixed automatically.

##########
File path: lib/go/Makefile
##########
@@ -35,7 +36,7 @@ export GO111MODULE
 
 # Only set PROTOC_VER if it has an empty value.
 ifeq (,$(strip $(PROTOC_VER)))
-PROTOC_VER := 3.5.1
+PROTOC_VER := 3.14

Review comment:
       Move to the a later version v3.16 is already there.

##########
File path: lib/go/Makefile
##########
@@ -19,6 +19,7 @@
 ifndef PROTOBUF_VERSION
 $(error PROTOBUF_VERSION is missing)
 endif
+PROTOBUF_VERSION := v1.20.0

Review comment:
       We should not override the version picked up earlier.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org