You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/01 15:55:18 UTC
[GitHub] [shardingsphere] lovepoem opened a new pull request #7684: Use mvnw command to unify the maven version
lovepoem opened a new pull request #7684:
URL: https://github.com/apache/shardingsphere/pull/7684
Use mvnw command to unify the maven version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7684: Use mvnw command to unify the maven version
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7684:
URL: https://github.com/apache/shardingsphere/pull/7684#discussion_r498370487
##########
File path: pom.xml
##########
@@ -748,13 +748,13 @@
<version>${cobertura-maven-plugin.version}</version>
<configuration>
<check>
- <!--<branchRate>85</branchRate>-->
- <!--<lineRate>85</lineRate>-->
- <!--<haltOnFailure>true</haltOnFailure>-->
- <!--<totalBranchRate>85</totalBranchRate>-->
- <!--<totalLineRate>85</totalLineRate>-->
- <!--<packageLineRate>85</packageLineRate>-->
- <!--<packageBranchRate>85</packageBranchRate>-->
+ <branchRate>85</branchRate>
+ <lineRate>85</lineRate>
+ <haltOnFailure>true</haltOnFailure>
+ <totalBranchRate>85</totalBranchRate>
+ <totalLineRate>85</totalLineRate>
+ <packageLineRate>85</packageLineRate>
+ <packageBranchRate>85</packageBranchRate>
Review comment:
The current test coverage is not reach to 85, it will cause compile error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7684: Use mvnw command to unify the maven version
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7684:
URL: https://github.com/apache/shardingsphere/pull/7684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org