You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by "Nathan Barry (JIRA)" <ji...@apache.org> on 2014/04/10 00:25:14 UTC

[jira] [Commented] (CRUNCH-374) Pipeline.done returns READY when there is nothing to run

    [ https://issues.apache.org/jira/browse/CRUNCH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964741#comment-13964741 ] 

Nathan Barry commented on CRUNCH-374:
-------------------------------------

Unfortunately returning a new status in this flow would be non-passive (a minor annoyance) whereas returning SUCCEEDED would be more passive than DONE but then we have added ambiguity to the meaning of that status.

> Pipeline.done returns READY when there is nothing to run
> --------------------------------------------------------
>
>                 Key: CRUNCH-374
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-374
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Nathan Barry
>            Priority: Minor
>
> It is odd that Pipeline.done() returns a PipelineResult with a status of “READY” when there is nothing staged in the pipeline when done is called.  It makes sense to not return “SUCCEEDED” as that implies that something happened successfully, but “READY” isn’t a terminal state but it’s an initial state so checking for a status of READY after calling done is counterintuitive. 
> Perhaps a new status of “DONE” should be returned in this case



--
This message was sent by Atlassian JIRA
(v6.2#6252)