You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/03 06:17:58 UTC

[GitHub] [kafka] chia7712 opened a new pull request #10628: MINOR: Mark case objects as final

chia7712 opened a new pull request #10628:
URL: https://github.com/apache/kafka/pull/10628


   follow scala best practices - Mark case objects as final
   (https://nrinaudo.github.io/scala-best-practices/adts/final_case_objects.html)
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10628: MINOR: Mark case objects as final

Posted by GitBox <gi...@apache.org>.

chia7712 commented on pull request #10628:
URL: https://github.com/apache/kafka/pull/10628#issuecomment-831060618


   > I think this is noisy without much value. I've never seen a problem caused by this in practice.
   
   Thanks for this response! close this ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 closed pull request #10628: MINOR: Mark case objects as final

Posted by GitBox <gi...@apache.org>.

chia7712 closed pull request #10628:
URL: https://github.com/apache/kafka/pull/10628


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10628: MINOR: Mark case objects as final

Posted by GitBox <gi...@apache.org>.

ijuma commented on pull request #10628:
URL: https://github.com/apache/kafka/pull/10628#issuecomment-831060008


   I think this is noisy without much value. I've never seen a problem caused by this in practice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org