You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/19 16:31:26 UTC

Review Request 39440: RU: Fix hbase snapshot

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39440/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-13474
    https://issues.apache.org/jira/browse/AMBARI-13474


Repository: ambari


Description
-------

Looks like someone has changed the function name in hbase script from snapshot() to take_snapshot() but looks like the upgrade pack (HDP 2.2 & 2.3) still reflects old function name.

https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py#L27


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml e54f0d8 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8c8db7c 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 08b34be 

Diff: https://reviews.apache.org/r/39440/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 39440: RU: Fix hbase snapshot

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.


> On Oct. 19, 2015, 10:06 p.m., Jonathan Hurley wrote:
> > Caused by: AMBARI-13378. Stop-and-Start Upgrade: Merge feature branch to trunk. (dgrinenko via dlysnichenko)
> > 
> > Looks like a simple matter of adding a new `restore_snapshot` function and renaming the existing one for consistency. Maybe double-check before commit, but patch looks good.

Yes, I checked. It's fixed in branch-2.1


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39440/#review103169
-----------------------------------------------------------


On Oct. 19, 2015, 2:31 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39440/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 2:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-13474
>     https://issues.apache.org/jira/browse/AMBARI-13474
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Looks like someone has changed the function name in hbase script from snapshot() to take_snapshot() but looks like the upgrade pack (HDP 2.2 & 2.3) still reflects old function name.
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py#L27
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml e54f0d8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8c8db7c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 08b34be 
> 
> Diff: https://reviews.apache.org/r/39440/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 39440: RU: Fix hbase snapshot

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39440/#review103169
-----------------------------------------------------------

Ship it!


Caused by: AMBARI-13378. Stop-and-Start Upgrade: Merge feature branch to trunk. (dgrinenko via dlysnichenko)

Looks like a simple matter of adding a new `restore_snapshot` function and renaming the existing one for consistency. Maybe double-check before commit, but patch looks good.

- Jonathan Hurley


On Oct. 19, 2015, 10:31 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39440/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 10:31 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-13474
>     https://issues.apache.org/jira/browse/AMBARI-13474
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Looks like someone has changed the function name in hbase script from snapshot() to take_snapshot() but looks like the upgrade pack (HDP 2.2 & 2.3) still reflects old function name.
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py#L27
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml e54f0d8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8c8db7c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 08b34be 
> 
> Diff: https://reviews.apache.org/r/39440/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 39440: RU: Fix hbase snapshot

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39440/#review103468
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 19, 2015, 2:31 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39440/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 2:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-13474
>     https://issues.apache.org/jira/browse/AMBARI-13474
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Looks like someone has changed the function name in hbase script from snapshot() to take_snapshot() but looks like the upgrade pack (HDP 2.2 & 2.3) still reflects old function name.
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py#L27
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml e54f0d8 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8c8db7c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 08b34be 
> 
> Diff: https://reviews.apache.org/r/39440/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>