You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/25 05:21:40 UTC

[GitHub] [apisix] nic-chen commented on pull request #2312: bugfix: create the etcd object in `xpcall`, it may fail, the return v…

nic-chen commented on pull request #2312:
URL: https://github.com/apache/apisix/pull/2312#issuecomment-698726024


   I checked the old version. we created a etcd cli only once here: 
   https://github.com/apache/apisix/blob/7f64ba810ef4ea9a105f7c3e8a83ac54e47ad58e/apisix/core/config_etcd.lua#L434-L446
   and then we could reuse it.
   
   I think we could use that mode.
   
   do you remember that change it? @Yiyiyimu 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org