You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/25 13:45:47 UTC

[GitHub] [skywalking] jgzl opened a new pull request #7011: add shutdown.sh

jgzl opened a new pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011


   add shutdown.sh
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jgzl edited a comment on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
jgzl edited a comment on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848096233


   > Please finish the Windows version too.
   
   windows版本不太好实现，目前实现的shutdown.bat版本需要把相关执行内容直接放到cmd中才可以停止java应用（还不如手动关闭startup.bat打开的弹窗来得方便）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #7011: [Not Merged][Nothing Changed][GitHub bug] add shutdown.sh

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848606274


   > > > @kezhenxu94 Why this PR shows merge?
   > > 
   > > 
   > > I have no idea either, I'm checking, might be a bug of GH, I just merged #7016
   > 
   > Yes, and this PR seems keeping nothing changed.
   
   OK, I think it's because the author installed the app https://github.com/apps/pull in their fork and when I merge #7016 , the app force pushes to their master branch, which is also the branch this PR uses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#discussion_r638810072



##########
File path: dist-material/bin/shutdown.sh
##########
@@ -0,0 +1,35 @@
+#!/usr/bin/env sh
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+OAP_NAME=org.apache.skywalking.oap.server.starter.OAPServerStartUp
+WEB_NAME=skywalking-webapp
+oapPID=`ps aux|grep $OAP_NAME|grep -v grep|awk '{print $2}'|xargs`
+webPID=`ps aux|grep $WEB_NAME|grep -v grep|awk '{print $2}'|xargs`

Review comment:
       Typically, the PID should be written by startup shell. Take a Tomcat as an example.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848372812


   But I still can see your `shutdown.bat`. If we don't need that, please remove it.
   
   The other thing is about `.sh`. We have separated shell scrips for OAP and UI, please make sure you shutdown script matching the pattern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jgzl commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
jgzl commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848096233


   > Please finish the Windows version too.
   
   windows版本不太好实现，目前实现的版本需要把相关执行内容直接放到cmd中才可以停止java应用（还不如手动关闭startup.sh来得方便）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-847890258


   Please finish the Windows version too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dmsolr commented on pull request #7011: [Not Merged][Nothing Changed][GitHub bug] add shutdown.sh

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848769638


   > @kezhenxu94 Why this PR shows merge?
   
   The same thing happened in [apisix-java-plugin-runner](https://github.com/apache/apisix-java-plugin-runner/pull/9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jgzl edited a comment on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
jgzl edited a comment on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848096233


   > Please finish the Windows version too.
   
   windows版本不太好实现，目前实现的shutdown.bat版本需要把相关执行内容直接放到cmd中才可以停止java应用（还不如手动关闭shutdown.bat来得方便）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #7011: [Not Merged][Nothing Changed][GitHub bug] add shutdown.sh

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848606274


   > > > @kezhenxu94 Why this PR shows merge?
   > > 
   > > 
   > > I have no idea either, I'm checking, might be a bug of GH, I just merged #7016
   > 
   > Yes, and this PR seems keeping nothing changed.
   
   OK, I think it's because the author installed the app https://github.com/apps/pull in their fork and when I merge #7016 , the app force pushes to their master branch, which is also the branch this PR uses.
   
   Anyway, the status ("merged") is not right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] dmsolr commented on pull request #7011: [Not Merged][Nothing Changed][GitHub bug] add shutdown.sh

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848781621


   Because it has been merged. 
   ![image](https://user-images.githubusercontent.com/29735230/119670266-56161d00-be6b-11eb-831f-397d405391af.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848599928


   > @kezhenxu94 Why this PR shows merge?
   
   I have no idea either, I'm checking, might be a bug of GH, I just merged #7016 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #7011: [Not Merged][Nothing Changed][GitHub bug] add shutdown.sh

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848772368


   > The same thing happened in [apisix-java-plugin-runner](https://github.com/apache/apisix-java-plugin-runner/pull/9).
   
   That PR's status is close, and I can see it's closed by the author, no?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 merged pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jgzl edited a comment on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
jgzl edited a comment on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848096233


   > Please finish the Windows version too.
   
   windows版本不太好实现，目前实现的shutdown.bat版本需要把相关执行内容直接放到cmd中才可以停止java应用（还不如手动关闭startup.bat来得方便）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jgzl commented on a change in pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
jgzl commented on a change in pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#discussion_r638813542



##########
File path: dist-material/bin/shutdown.sh
##########
@@ -0,0 +1,35 @@
+#!/usr/bin/env sh
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+OAP_NAME=org.apache.skywalking.oap.server.starter.OAPServerStartUp
+WEB_NAME=skywalking-webapp
+oapPID=`ps aux|grep $OAP_NAME|grep -v grep|awk '{print $2}'|xargs`
+webPID=`ps aux|grep $WEB_NAME|grep -v grep|awk '{print $2}'|xargs`

Review comment:
       Ok, I'll refer to the stop and start script of Tomcat




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848357038


   > > Please finish the Windows version too.
   > 
   > 
   > 
   > windows版本不太好实现，目前实现的shutdown.bat版本需要把相关执行内容直接放到cmd中才可以停止java应用（还不如手动关闭startup.bat打开的弹窗来得方便）
   
   Please keep using English on Github. We need all things available to the global.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848597155


   @kezhenxu94 Why this PR shows merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #7011: add shutdown.sh

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7011:
URL: https://github.com/apache/skywalking/pull/7011#issuecomment-848602534


   > > @kezhenxu94 Why this PR shows merge?
   > 
   > I have no idea either, I'm checking, might be a bug of GH, I just merged #7016
   
   Yes, and this PR seems keeping nothing changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org