You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/07 06:01:23 UTC

[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3388: Add static declaration for useFallocate in DirectWriter

wenbingshen commented on code in PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#discussion_r915488071


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectWriter.java:
##########
@@ -49,7 +49,6 @@ class DirectWriter implements LogWriter {
     final List<Future<?>> outstandingWrites = new ArrayList<Future<?>>();
     Buffer nativeBuffer;
     long offset;
-    private volatile boolean useFallocate = true;

Review Comment:
   It makes sense to me. I have addressed your comment. PTAL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org