You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/07 12:41:05 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #3670: binnfmt:Fix return before close ELF fd

davids5 opened a new pull request #3670:
URL: https://github.com/apache/incubator-nuttx/pull/3670


      elf_init open a elf file , if both enabled
      CONFIG_NSH_BUIlTAPPS and CONFIG_NSH_FILE_APPS ,
      elf_init will read elf file in /bin directory, but
      that length is zero , elf_read failed return and NOT
      close elf fd, so this line MUST be return to errout_with_init
   
   ## Summary
   
   This was an old PR to PX4 See https://github.com/PX4/NuttX/pull/67 that the author forgot to upstream 
   
   ## Impact
   
   FD leak
   
   ## Testing
   
   Inspection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3670: binnfmt:Fix return before close ELF fd

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 merged pull request #3670:
URL: https://github.com/apache/incubator-nuttx/pull/3670


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org