You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2024/12/12 06:52:29 UTC

[PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

SteNicholas opened a new pull request, #2994:
URL: https://github.com/apache/celeborn/pull/2994

   ### What changes were proposed in this pull request?
   
   Update default value of `celeborn.<module>.io.mode` to whether epoll mode is available.
   
   ### Why are the changes needed?
   
   The JDK NIO bug produces the situation that empty polling of `Selector` could cause CPU 100%, which refers to
   
   1. [JDK-2147719 : (se) Selector doesn't block on Selector.select(timeout) (lnx)](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=2147719)
   2. [JDK-6403933 : (se) Selector doesn't block on Selector.select(timeout) (lnx)](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933)
   
   When the epoll mode is available, the default IO mode should be `EPOLL`, which backports [NettyServer.java#L92](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java#L92).
   
   ### Does this PR introduce _any_ user-facing change?
   
   Change the default value of `celeborn.<module>.io.mode`.
   
   ### How was this patch tested?
   
   CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887931876


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   @turboFei, IMO, according to constructor of `NativeIoException`, `NativeIoException` has no cause and the message could only check whether message contains the `method` which is `bind`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1883063618


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1918,11 +1920,12 @@ object CelebornConf extends Logging {
   val NETWORK_IO_MODE: ConfigEntry[String] =
     buildConf("celeborn.<module>.io.mode")
       .categories("network")
-      .doc("Netty EventLoopGroup backend, available options: NIO, EPOLL.")
+      .doc("Netty EventLoopGroup backend, available options: NIO, EPOLL. The default IO mode is EPOLL for the available epoll mode.")

Review Comment:
   nit:
   ```
   If epoll mode is available, the default IO mode is EPOLL; otherwise, it defaults to NIO.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1882191317


##########
common/src/test/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnvSuite.scala:
##########
@@ -42,7 +43,7 @@ class NettyRpcEnvSuite extends RpcEnvSuite with TimeLimits {
       port: Int,
       clientMode: Boolean = false): RpcEnv = {
     val config = RpcEnvConfig(
-      conf,
+      conf.set(s"celeborn.$transportModule.io.mode", IOMode.NIO.name()),

Review Comment:
   The test case `port conflict` has exception that `io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use` for using default `EPOLL` io mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887886999


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   The current code also looks good to me 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1882262548


##########
common/src/main/java/org/apache/celeborn/common/network/server/TransportServer.java:
##########
@@ -100,6 +101,7 @@ private void init(String hostToBind, int portToBind) {
             .channel(NettyUtils.getServerChannelClass(ioMode))
             .option(ChannelOption.ALLOCATOR, allocator)
             .option(ChannelOption.SO_REUSEADDR, !SystemUtils.IS_OS_WINDOWS)
+            .option(EpollChannelOption.SO_REUSEPORT, IOMode.EPOLL.equals(ioMode))

Review Comment:
   The test case `port conflict` has exception that `io.netty.channel.unix.Errors$NativeIoException: bind(..)` for epoll io mode. Therefore, we could set `EpollChannelOption.SO_REUSEPORT` to true for epoll io mode to avoid exception of port conflict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2539131713

   Ping @pan3793, @RexXiong, @FMX.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2994: [CELEBORN-1774] Update default value of celeborn.<module>.io.mode to whether epoll mode is available
URL: https://github.com/apache/celeborn/pull/2994


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2545471179

   @FMX, @RexXiong, could you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887931876


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   @turboFei, IMO, according to constructor of `NativeIoException`, `NativeIoException` has no cause and the message could only check whether message contains the `method` which is `bind`.
   ```
   public NativeIoException(String method, int expectedErr) {
       this(method, expectedErr, true);
   }
   
   public NativeIoException(String method, int expectedErr, boolean fillInStackTrace) {
        super(method + "(..) failed: " + errnoString(-expectedErr));
        this.expectedErr = expectedErr;
        this.fillInStackTrace = fillInStackTrace;
   }
   ```
   The exception message is ` io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887884999


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   Can it pass with?
   ```
   (e.getMessage != null && e.getMessage.startsWith("bind(..) failed: ")) ||
             isBindCollision(e.getCause)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887833744


##########
common/src/main/java/org/apache/celeborn/common/network/server/TransportServer.java:
##########
@@ -100,6 +101,7 @@ private void init(String hostToBind, int portToBind) {
             .channel(NettyUtils.getServerChannelClass(ioMode))
             .option(ChannelOption.ALLOCATOR, allocator)
             .option(ChannelOption.SO_REUSEADDR, !SystemUtils.IS_OS_WINDOWS)
+            .option(EpollChannelOption.SO_REUSEPORT, IOMode.EPOLL.equals(ioMode))

Review Comment:
   The use of SO_REUSEPORT may lead to issues if the Celeborn worker attempts to bind to a port that is already in use by another process. Could we fix the exception in ut?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2547462773

   @RexXiong, thanks for review. I have found the epoll bug for Utils#isBindCollision, which error message refers to [Errors.java#L87](https://github.com/netty/netty/blob/netty-4.1.109.Final/transport-native-unix-common/src/main/java/io/netty/channel/unix/Errors.java#L87). PTAL. cc @turboFei, @pan3793.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887931876


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   @turboFei, IMO, according to constructor of `NativeIoException`, `NativeIoException` has no cause and the message could only check whether message contains the `method` which is `bind`.
   ```
   public NativeIoException(String method, int expectedErr) {
       this(method, expectedErr, true);
   }
   
   public NativeIoException(String method, int expectedErr, boolean fillInStackTrace) {
        super(method + "(..) failed: " + errnoString(-expectedErr));
        this.expectedErr = expectedErr;
        this.fillInStackTrace = fillInStackTrace;
   }
   ```
   The exception message is `io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2547470678

   @RexXiong, thanks for review. I have found the epoll bug for `Utils#isBindCollision`, which error message refers to [Errors.java#L87](https://github.com/netty/netty/blob/netty-4.1.109.Final/transport-native-unix-common/src/main/java/io/netty/channel/unix/Errors.java#L87). PTAL. cc @turboFei, @pan3793.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887886999


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   The current code also looks good to me 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1883062266


##########
docs/migration.md:
##########
@@ -29,6 +29,8 @@ license: |
 
 - Since 0.6.0, Celeborn changed the default value of `celeborn.client.spark.fetch.throwsFetchFailure` from `false` to `true`, which means Celeborn will enable spark stage rerun at default.
 
+- Since 0.6.0, Celeborn changed the default value of `celeborn.<module>.io.mode` from `NIO` to whether epoll mode is available, which means Celeborn will regard `EPOLL` as the default IO mode for the available epoll mode.

Review Comment:
   ```
   - Since 0.6.0, Celeborn changed the default value of `celeborn.<module>.io.mode` from `NIO` to EPOLL if epoll mode is available, otherwise, it will fall back to NIO.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1882191317


##########
common/src/test/scala/org/apache/celeborn/common/rpc/netty/NettyRpcEnvSuite.scala:
##########
@@ -42,7 +43,7 @@ class NettyRpcEnvSuite extends RpcEnvSuite with TimeLimits {
       port: Int,
       clientMode: Boolean = false): RpcEnv = {
     val config = RpcEnvConfig(
-      conf,
+      conf.set(s"celeborn.$transportModule.io.mode", IOMode.NIO.name()),

Review Comment:
   The test case `port conflict` has exception that `io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use` for using default `EPOLL` io mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1883062266


##########
docs/migration.md:
##########
@@ -29,6 +29,8 @@ license: |
 
 - Since 0.6.0, Celeborn changed the default value of `celeborn.client.spark.fetch.throwsFetchFailure` from `false` to `true`, which means Celeborn will enable spark stage rerun at default.
 
+- Since 0.6.0, Celeborn changed the default value of `celeborn.<module>.io.mode` from `NIO` to whether epoll mode is available, which means Celeborn will regard `EPOLL` as the default IO mode for the available epoll mode.

Review Comment:
   NIT:
   ```
   - Since 0.6.0, Celeborn changed the default value of `celeborn.<module>.io.mode` from `NIO` to EPOLL if epoll mode is available, otherwise, it will fall back to NIO.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2539052776

   Ping @pan3793, @FMX, @RexXiong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2547451886

   @RexXiong, thanks for review. I have found the epoll bug for `Utils#isBindCollision`, which error message refers to [Errors.java#L87](https://github.com/netty/netty/blob/netty-4.1.109.Final/transport-native-unix-common/src/main/java/io/netty/channel/unix/Errors.java#L87). PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#discussion_r1887884999


##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -328,8 +328,7 @@ object Utils extends Logging {
         }
         isBindCollision(e.getCause)
       case e: NativeIoException =>
-        (e.getMessage != null && e.getMessage.startsWith("bind() failed: ")) ||
-          isBindCollision(e.getCause)
+        e.getMessage != null && e.getMessage.startsWith("bind")

Review Comment:
   Can it pass with
   ```
   (e.getMessage != null && e.getMessage.startsWith("bind(..) failed: ")) ||
             isBindCollision(e.getCause)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1774] Update default value of celeborn..io.mode to whether epoll mode is available [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2994:
URL: https://github.com/apache/celeborn/pull/2994#issuecomment-2547688030

   Merge to main(v0.6.0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org