You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/28 19:04:00 UTC
[jira] [Commented] (ARTEMIS-1713) Calling getClientId() on an
OpenWireConnection can cause a NPE
[ https://issues.apache.org/jira/browse/ARTEMIS-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380846#comment-16380846 ]
ASF GitHub Bot commented on ARTEMIS-1713:
-----------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1910
ARTEMIS-1713 - Fix NPE inside OpenWireConnection
fix NPE inside getClientId() in OpenWireConnection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1713
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1910.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1910
----
commit 8bd0d8aad684872273e0d3e34a280a5ebe0e531e
Author: Christopher L. Shannon (cshannon) <ch...@...>
Date: 2018-02-28T19:01:51Z
ARTEMIS-1713 - Fix NPE inside OpenWireConnection
fix NPE inside getClientId() in OpenWireConnection
----
> Calling getClientId() on an OpenWireConnection can cause a NPE
> --------------------------------------------------------------
>
> Key: ARTEMIS-1713
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1713
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 2.4.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.5.0
>
>
> The getClientId() on RemotingConnection is public and it is possible to call it too early on an OpenWireConnection (such as in a plugin) before the context has been initialized with the clientId. Instead of just returning null a NPE is thrown because of a null reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)