You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/04 05:04:04 UTC
[jira] [Commented] (THRIFT-2983) Replace use of deprecated -[NSData
getBytes:] in -[TNSFileHandleTransport readAll:offset:length:]
[ https://issues.apache.org/jira/browse/THRIFT-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346350#comment-14346350 ]
ASF GitHub Bot commented on THRIFT-2983:
----------------------------------------
GitHub user jeremy-w opened a pull request:
https://github.com/apache/thrift/pull/386
THRIFT-2983: replaces deprecated -[NSData getBytes:] with -getBytes:length:
One fewer warning in Xcode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeremy-w/thrift addresses-deprecation-warning-THRIFT-2983
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/386.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #386
----
commit d2da89cd6831874299e2cd8a10fd2b8fe3a837bf
Author: Jeremy W. Sherman <je...@gmail.com>
Date: 2015-03-04T04:01:27Z
THRIFT-2983: replaces deprecated -[NSData getBytes:] with -[NSData getBytes:length:]
----
> Replace use of deprecated -[NSData getBytes:] in -[TNSFileHandleTransport readAll:offset:length:]
> --------------------------------------------------------------------------------------------------
>
> Key: THRIFT-2983
> URL: https://issues.apache.org/jira/browse/THRIFT-2983
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Library
> Affects Versions: 0.9.2
> Reporter: Jeremy W. Sherman
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> It looks like the access is actually safe; the code just needs to provide the known length to -getBytes:length: and this will be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)