You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2009/04/14 09:21:16 UTC

[jira] Resolved: (HARMONY-6125) [classlib][luni] - remove duplicated security check in File.list

     [ https://issues.apache.org/jira/browse/HARMONY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu resolved HARMONY-6125.
-------------------------------

    Resolution: Fixed

applied at r764692.

> [classlib][luni] - remove duplicated security check in File.list
> ----------------------------------------------------------------
>
>                 Key: HARMONY-6125
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6125
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Regis Xu
>         Attachments: File.list.refactor.diff
>
>
> in the list implementation:
>         SecurityManager security = System.getSecurityManager();
>         if (security != null) {
>             security.checkRead(path);
>         }
>         if (!isDirectory() || !canRead()) {
>             return null;
>         }
> isDirectory and canRead also check security by security.checkRead, it's unnecessary and time cost. I'll attach patch to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.