You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/04/28 23:42:33 UTC

Re: cvs commit: modperl-2.0/t/conf modperl_extra.pl

stas@apache.org wrote:
> stas        2004/04/28 14:29:39
> 
>   Modified:    t/conf   modperl_extra.pl
>   Log:
>   - log the reason for the last change:
>     http://rt.perl.org:80/rt3/Ticket/Display.html?id=29018
>   - tidy up a bit
>   
>   Revision  Changes    Path
>   1.46      +10 -4     modperl-2.0/t/conf/modperl_extra.pl
>   
>   Index: modperl_extra.pl
>   ===================================================================
>   RCS file: /home/cvs/modperl-2.0/t/conf/modperl_extra.pl,v
>   retrieving revision 1.45
>   retrieving revision 1.46
>   diff -u -u -r1.45 -r1.46
>   --- modperl_extra.pl	23 Apr 2004 00:38:33 -0000	1.45
>   +++ modperl_extra.pl	28 Apr 2004 21:29:38 -0000	1.46
>   @@ -197,11 +197,17 @@
>        warn "END in modperl_extra.pl, pid=$$\n";
>    }
>    
>   -#For the tied %Location in <Perl > sections
>   +package Tie::PerlSection;
>   +
>   +# the following is needed for the tied %Location test in <Perl>
>   +# sections. Unfortunately it can't be defined in the section itself
>   +# due to the bug in perl:
>   +# http://rt.perl.org:80/rt3/Ticket/Display.html?id=29018
>   +
>    use Tie::Hash;
>   -@Tie::PerlSection::ISA = qw(Tie::StdHash);
>   -sub Tie::PerlSection::FETCH {

gozer, do you think we should use a different namespace for this thing? In 
case someone decides to have their own Tie::PerlSection? e.g.
s/Tie::PerlSection/ModPerl::TestTiePerlSection/?

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl-2.0/t/conf modperl_extra.pl

Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.

Stas Bekman wrote:
> stas@apache.org wrote:
> 
>>stas        2004/04/28 14:29:39
>>
>>  Modified:    t/conf   modperl_extra.pl
>>  Log:
>>  - log the reason for the last change:
>>    http://rt.perl.org:80/rt3/Ticket/Display.html?id=29018
>>  - tidy up a bit
>>  
>>  Revision  Changes    Path
>>  1.46      +10 -4     modperl-2.0/t/conf/modperl_extra.pl
>>  
>>  Index: modperl_extra.pl
>>  ===================================================================
>>  RCS file: /home/cvs/modperl-2.0/t/conf/modperl_extra.pl,v
>>  retrieving revision 1.45
>>  retrieving revision 1.46
>>  diff -u -u -r1.45 -r1.46
>>  --- modperl_extra.pl	23 Apr 2004 00:38:33 -0000	1.45
>>  +++ modperl_extra.pl	28 Apr 2004 21:29:38 -0000	1.46
>>  @@ -197,11 +197,17 @@
>>       warn "END in modperl_extra.pl, pid=$$\n";
>>   }
>>   
>>  -#For the tied %Location in <Perl > sections
>>  +package Tie::PerlSection;
>>  +
>>  +# the following is needed for the tied %Location test in <Perl>
>>  +# sections. Unfortunately it can't be defined in the section itself
>>  +# due to the bug in perl:
>>  +# http://rt.perl.org:80/rt3/Ticket/Display.html?id=29018
>>  +
>>   use Tie::Hash;
>>  -@Tie::PerlSection::ISA = qw(Tie::StdHash);
>>  -sub Tie::PerlSection::FETCH {
> 
> 
> gozer, do you think we should use a different namespace for this thing? In 
> case someone decides to have their own Tie::PerlSection? e.g.
> s/Tie::PerlSection/ModPerl::TestTiePerlSection/?

Yeah, I guess polluing the Tie::* namespace for the tests isn't quite nice.
I'll fix it.


-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5