[jira] [Commented] (OOZIE-1589) TestZKLocksService is flakey

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801345#comment-13801345 ] 

Hadoop QA commented on OOZIE-1589:
----------------------------------

Testing JIRA OOZIE-1589

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 1347
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/851/

> TestZKLocksService is flakey
> ----------------------------
>
>                 Key: OOZIE-1589
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1589
>             Project: Oozie
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1589.patch
>
>
> TestZKLocksService is highly dependent on the order of things happening because its testing locks.  I've seen tests in this class fail a number of times with messages like this:
> {noformat}
> expected:<a:[1-L a:2-L a:1-U] a:2-U> but was:<a:[2-L a:1-L] a:2-U>
> {noformat}
> which is because things happened in a slightly different order than it was expecting (though everything is happening correctly)
> When I created these tests, I just took the TestLockService and made it use ZKLocks instead of MemoryLocks.  The ZKLocks take longer to lock than the MemoryLocks, so the timings are sometimes too fast.  I think we just need to increase the sleep calls, and use the {{sleep()}} method instead of {{Thread.sleep()}} so it will scale with the "waitfor ratio" on slower machines.



--
This message was sent by Atlassian JIRA
(v6.1#6144)