[GitHub] [pinot] walterddr commented on a diff in pull request #9821: [multistage] add comparison tests

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9821:
URL: https://github.com/apache/pinot/pull/9821#discussion_r1025750516


##########
pinot-query-runtime/src/test/resources/queries/Comparisons.json:
##########
@@ -0,0 +1,481 @@
+{
+  "ints": {

Review Comment:
   nit: this could be improvement points on the test framework side. 
   
   but since we don't differentiate tables registered by different files. might be great to add a more unique name of the test such as `ints_comparison` this is to avoid registering 2 `ints_tbl` from 2 different test json files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org