You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/03/30 08:45:44 UTC
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/534
CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project
### Platforms affected
iOS
### What does this PR do?
Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform
### What testing has been done on this change?
Added unit tests to `cordova-lib\spec-plugman\platforms\ios,spec.js`
### Other notes
The same code and tests will be added to the Platform API of cordova-ios as appropriate.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-XXXX"
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/534
cordova-platform-test `latest` tag was changed back to `6.2.0-dev` and should fix this issue. Closing and re-opening to trigger CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/534
Looks like the AppVeyor failure is node 6 only, which is suspicious and probably a hiccup:
```
1) HooksRunner fire method plugin hooks Test 011 : should filter hook scripts from plugin.xml by platform
Message:
Expected Error: Hook failed with error code 1: C:\Users\appveyor\AppData\Local\Temp\1\e2e-test\hooks_test\project\hooks\before_build\hookScript02.bat to be undefined.
Stack:
Error: Expected Error: Hook failed with error code 1: C:\Users\appveyor\AppData\Local\Temp\1\e2e-test\hooks_test\project\hooks\before_build\hookScript02.bat to be undefined.
at C:\projects\cordova-lib\cordova-lib\spec-cordova\HooksRunner.spec.js:406:33
at _rejected (C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:797:24)
at C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:823:30
at Promise.when (C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:1035:31)
```
Thanks to @stevengill for the review. Seems any changes to `cordova-lib/src/plugman/platforms/ios.js` should be removed since in cordova@7 everything will be in the Platform API. I will close this PR and send a new (trivial) one for the `cordova-common` changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
GitHub user shazron reopened a pull request:
https://github.com/apache/cordova-lib/pull/534
CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project
### Platforms affected
iOS
### What does this PR do?
Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform
### What testing has been done on this change?
Added unit tests to `cordova-lib\spec-plugman\platforms\ios.spec.js`
### Other notes
Complementary PR: https://github.com/apache/cordova-ios/pull/299
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-XXXX"
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit c3f4dcfca6bdc8b23cf4f46d49aca7abec449cb6
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-03-30T08:39:43Z
CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/534
Moved to https://github.com/apache/cordova-lib/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-lib/pull/534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Posted by audreyso <gi...@git.apache.org>.
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/534
@shazron I believe that is expected because something was changed with a test platform from npm. We should ignore it temporarily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/534
Getting unrelated test error:
```
1) non-core platform add and rm end-to-end --fetch Test 009 : should add and remove 3rd party platforms
Message:
Expected Error: /tmp/e2e-test/non-core-platform-test/hello/node_modules/cordova-platform-test/bin/create: Command failed with exit code ENOENT to be undefined.
Stack:
Error: Expected Error: /tmp/e2e-test/non-core-platform-test/hello/node_modules/cordova-platform-test/bin/create: Command failed with exit code ENOENT to be undefined.
at /home/travis/build/apache/cordova-lib/cordova-lib/spec-cordova/platform.spec.js:414:25
at _rejected (/home/travis/build/apache/cordova-lib/cordova-lib/node_modules/q/q.js:797:24)
at /home/travis/build/apache/cordova-lib/cordova-lib/node_modules/q/q.js:823:30
at Promise.when (/home/travis/build/apache/cordova-lib/cordova-lib/node_modules/q/q.js:1035:31)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-lib/pull/534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #534: CB-11233 - Support installing frameworks into "Embed...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/534
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=h1) Report
> Merging [#534](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/4c99c0d4e08c5a48ab5d2d48e627b58c45c4b8d2?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 68 68
Lines 5461 5461
Branches 1070 1070
=======================================
Hits 4501 4501
Misses 960 960
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/plugman/platforms/ios.js](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2lvcy5qcw==) | `82.16% <100%> (�)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=footer). Last update [4c99c0d...509b027](https://codecov.io/gh/apache/cordova-lib/pull/534?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
GitHub user shazron reopened a pull request:
https://github.com/apache/cordova-lib/pull/534
CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project
### Platforms affected
iOS
### What does this PR do?
Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform
### What testing has been done on this change?
Added unit tests to `cordova-lib\spec-plugman\platforms\ios,spec.js`
### Other notes
Complementary PR: https://github.com/apache/cordova-ios/pull/299
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-XXXX"
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11233
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit c3f4dcfca6bdc8b23cf4f46d49aca7abec449cb6
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-03-30T08:39:43Z
CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #534: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-lib/pull/534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org