You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/16 23:22:43 UTC

[GitHub] [spark] xinrong-databricks commented on pull request #33964: [SPARK-36746][PYTHON] Refactor `_select_rows_by_iterable` in `iLocIndexer` to use `Column.isin`

xinrong-databricks commented on pull request #33964:
URL: https://github.com/apache/spark/pull/33964#issuecomment-921328484


   After a rough benchmark, `Column.isin` performs 3 times as fast as the long projection approach. So the PR is updated to use `Column.isin` even exceeding the `compute.isin_limit`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org