You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Steven Phillips <sp...@maprtech.com> on 2015/07/06 23:42:44 UTC
Review Request 36222: Patch for DRILL-3393
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36222/
-----------------------------------------------------------
Review request for drill.
Bugs: DRILL-3393
https://issues.apache.org/jira/browse/DRILL-3393
Repository: drill-git
Description
-------
DRILL-3393: Fix bug with quotes in TSV files
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java 38995093ed3cf60a9e84a95173bfb85611145f28
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f97f92ddc3e26e9a3789212c1b7708ec770
exec/java-exec/src/test/resources/textinput/input3.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/36222/diff/
Testing
-------
Thanks,
Steven Phillips
Re: Review Request 36222: Patch for DRILL-3393
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36222/#review90715
-----------------------------------------------------------
+1, there is one small comment about unit test name
- abdelhakim deneche
On July 6, 2015, 9:42 p.m., Steven Phillips wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36222/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 9:42 p.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-3393
> https://issues.apache.org/jira/browse/DRILL-3393
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3393: Fix bug with quotes in TSV files
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java 38995093ed3cf60a9e84a95173bfb85611145f28
> exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f97f92ddc3e26e9a3789212c1b7708ec770
> exec/java-exec/src/test/resources/textinput/input3.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36222/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Phillips
>
>
Re: Review Request 36222: Patch for DRILL-3393
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36222/#review90713
-----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java (line 40)
<https://reviews.apache.org/r/36222/#comment143854>
shouldn't this read drill_3393() ?
- abdelhakim deneche
On July 6, 2015, 9:42 p.m., Steven Phillips wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36222/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 9:42 p.m.)
>
>
> Review request for drill.
>
>
> Bugs: DRILL-3393
> https://issues.apache.org/jira/browse/DRILL-3393
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3393: Fix bug with quotes in TSV files
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextReader.java 38995093ed3cf60a9e84a95173bfb85611145f28
> exec/java-exec/src/test/java/org/apache/drill/exec/store/text/TestNewTextReader.java 76674f97f92ddc3e26e9a3789212c1b7708ec770
> exec/java-exec/src/test/resources/textinput/input3.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36222/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Phillips
>
>