You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/09/23 10:12:12 UTC

[GitHub] zeppelin pull request #1453: [ZEPPELIN-1482] Load updated dependency library...

GitHub user minahlee opened a pull request:

    https://github.com/apache/zeppelin/pull/1453

    [ZEPPELIN-1482] Load updated dependency library on interpreter restart

    ### What is this PR for?
    If user specifies library path in interpreter dependency setting, even when the file on this path is updated, new file doesn't take effect on interpreter _restart_ but does only when user _clicks Edit -> Save._
    The mechanism of dependency loading is copying all dependency libraries under `local-repo/
    {interpreterId}` and add these directory to classpath of interpreter process. Zeppelin copies these dependencies either on Zeppelin startup or dependency saving/editing.
    
    This PR checks if the library on specified local path is updated, and copy them to `local-repo/
    {interpreterId}` on restart if there is change.
    
    ### What type of PR is it?
    Bug Fix & Improvement
    
    ### What is the Jira issue?
    [ZEPPELIN-1482](https://issues.apache.org/jira/browse/ZEPPELIN-1482)
    
    ### How should this be tested?
    1. Download commons-csv-1.1.jar and commons-csv-1.2.jar to /my/path
    2. cp commons-csv-1.2.jar /my/path/commons-csv.jar
    3. Set dependency artifact of spark interpreter to /my/path/commons-csv.jar
    4. Run `%spark import org.apache.commons.csv.CSVFormat.Predefined` in paragraph and see if it runs without error
    5. cp commons-csv-1.1.jar /my/path/commons-csv.jar
    6. Restart spark interpreter
    7. Run `%spark import org.apache.commons.csv.CSVFormat.Predefined` in paragraph and see if error occurs.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1482

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1453
    
----
commit 6662e930b4e51e2ff9195a0c8dfbf1bf9029d837
Author: Mina Lee <mi...@apache.org>
Date:   2016-09-23T08:51:39Z

    Check if dependency library on specified path has changed and copy them under local-repo/{interpreterId} on interpreter restart

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1453: [ZEPPELIN-1482] Load updated dependency library on int...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1453
  
    Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1453: [ZEPPELIN-1482] Load updated dependency library...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1453


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1453: [ZEPPELIN-1482] Load updated dependency library on int...

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1453
  
    Merging if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---