You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2023/01/17 06:57:04 UTC
[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8697: change: rename kms to secret
shreemaan-abhishek opened a new pull request, #8697:
URL: https://github.com/apache/apisix/pull/8697
### Description
In some places, `kms` was not renamed to `Secret`. This has been fixed.
Ref: #8448
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY merged pull request #8697: docs: rename kms to secret
Posted by GitBox <gi...@apache.org>.
SylviaBABY merged PR #8697:
URL: https://github.com/apache/apisix/pull/8697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8697: change: rename kms to secret
Posted by GitBox <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #8697:
URL: https://github.com/apache/apisix/pull/8697#discussion_r1071815182
##########
docs/en/latest/admin-api.md:
##########
@@ -1392,7 +1392,7 @@ Example Configuration:
Example API usage:
```shell
-curl -i http://127.0.0.1:9180/apisix/admin/kms/vault/test2 \
+curl -i http://127.0.0.1:9180/apisix/admin/secret/vault/test2 \
Review Comment:
```suggestion
curl -i http://127.0.0.1:9180/apisix/admin/secrets/vault/test2 \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a diff in pull request #8697: change: rename kms to secret
Posted by GitBox <gi...@apache.org>.
soulbird commented on code in PR #8697:
URL: https://github.com/apache/apisix/pull/8697#discussion_r1071805459
##########
docs/en/latest/admin-api.md:
##########
@@ -1350,13 +1350,13 @@ Stream Route resource request address: /apisix/admin/stream_routes/{id}
To learn more about filtering in stream proxies, check [this](./stream-proxy.md#more-route-match-options) document.
-## kms
+## Secret
-kms means `Secrets Management`, which could use any secret manager supported, e.g. `vault`.
+Secret means `Secrets Management`, which could use any secret manager supported, e.g. `vault`.
-### kms API
+### Secret API
-kms resource request address: /apisix/admin/kms/{secretmanager}/{id}
+Secret resource request address: /apisix/admin/secret/{secretmanager}/{id}
Review Comment:
Should be `/apisix/admin/secrets/{secretmanager}/{id}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8697: change: rename kms to secret
Posted by GitBox <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #8697:
URL: https://github.com/apache/apisix/pull/8697#discussion_r1071812789
##########
docs/en/latest/admin-api.md:
##########
@@ -1350,13 +1350,13 @@ Stream Route resource request address: /apisix/admin/stream_routes/{id}
To learn more about filtering in stream proxies, check [this](./stream-proxy.md#more-route-match-options) document.
-## kms
+## Secret
-kms means `Secrets Management`, which could use any secret manager supported, e.g. `vault`.
+Secret means `Secrets Management`, which could use any secret manager supported, e.g. `vault`.
-### kms API
+### Secret API
-kms resource request address: /apisix/admin/kms/{secretmanager}/{id}
+Secret resource request address: /apisix/admin/secret/{secretmanager}/{id}
Review Comment:
```suggestion
Secret resource request address: /apisix/admin/secrets/{secretmanager}/{id}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #8697: change: rename kms to secret
Posted by GitBox <gi...@apache.org>.
soulbird commented on PR #8697:
URL: https://github.com/apache/apisix/pull/8697#issuecomment-1385054707
The content in this PR only includes the documentation part, so the title should be docs: xxxxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org