You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/10/28 09:49:05 UTC
[GitHub] spark pull request #22869: [SPARK-25758][ML] Deprecate computeCost in Bisect...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/22869
[SPARK-25758][ML] Deprecate computeCost in BisectingKMeans
## What changes were proposed in this pull request?
The PR proposes to deprecate the `computeCost` method on `BisectingKMeans` in favor of the adoption of `ClusteringEvaluator` in order to evaluate the clustering.
## How was this patch tested?
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-25758_3.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22869
----
commit ea5ccb80941d54e191b42d1a9ba685f88cceb488
Author: Marco Gaido <ma...@...>
Date: 2018-10-28T09:47:38Z
[SPARK-25758][ML] Deprecate computeCost in BisectingKMeans
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4572/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22869
**[Test build #98168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98168/testReport)** for PR 22869 at commit [`ea5ccb8`](https://github.com/apache/spark/commit/ea5ccb80941d54e191b42d1a9ba685f88cceb488).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22869: [SPARK-25758][ML] Deprecate computeCost in Bisect...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22869
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22869
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98168/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22869
**[Test build #98168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98168/testReport)** for PR 22869 at commit [`ea5ccb8`](https://github.com/apache/spark/commit/ea5ccb80941d54e191b42d1a9ba685f88cceb488).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22869
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by dbtsai <gi...@git.apache.org>.
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22869
LGTM too. Merged into master. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22869
Since https://github.com/apache/spark/pull/22756 was reverted because it was decided not to deprecate this in 2.4, but only in 3.0, this PR deprecates it for 3.0.
cc @cloud-fan @dongjoon-hyun @mengxr @srowen @WeichenXu123
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22869
any comments on this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22869: [SPARK-25758][ML] Deprecate computeCost in BisectingKMea...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22869
cc @dbtsai
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org