You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Wellington Chevreuil (Jira)" <ji...@apache.org> on 2021/05/27 14:40:00 UTC

[jira] [Created] (HBASE-25933) Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder

Wellington Chevreuil created HBASE-25933:
--------------------------------------------

             Summary: Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder
                 Key: HBASE-25933
                 URL: https://issues.apache.org/jira/browse/HBASE-25933
             Project: HBase
          Issue Type: Improvement
            Reporter: Wellington Chevreuil
            Assignee: Wellington Chevreuil


In *NettyRpcServerRequestDecoder,* override of *exceptionCaught* method tries to log the exception cause message, however this not always will have a content, causing debugging of connection failure issues harder to troubleshooting. We should simply log trace the observed *Throwable* reference itself:

 
{noformat}

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
index 1e844bb02cb..40f59ad1259 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java
@@ -74,7 +74,7 @@ class NettyRpcServerRequestDecoder extends ChannelInboundHandlerAdapter {
   public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {
     allChannels.remove(ctx.channel());
     NettyRpcServer.LOG.trace("Connection {}; caught unexpected downstream exception.",
-        ctx.channel().remoteAddress(), e.getCause());
+        ctx.channel().remoteAddress(), e);
     ctx.channel().close();
   }
 }
 {noformat}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)