You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2007/08/20 05:37:28 UTC
Re: svn commit: r26195 - in trunk: . subversion/include subversion/libsvn_subr subversion/tests/libsvn_subr
Hi Blair
On 8/19/07, blair@tigris.org <bl...@tigris.org> wrote:
> Author: blair
> Date: Sun Aug 19 19:01:22 2007
> New Revision: 26195
>
> Log:
> Add a new svn_parse_revision_number() method that behaves much like
> strtol() but returns only non-negative svn_revnum_t's.
>
> * subversion/include/svn_types.h
> (svn_parse_revision_number):
> New declaration.
>
>
> * subversion/tests/libsvn_subr/revision-test.c:
> New file based off of subversion/tests/libsvn_subr/time-test.c to
> test svn_parse_revision_number().
>
>
I needed the patche below to get it to compile (you must be using C++?).
--
Joe
Index: subversion/tests/libsvn_subr/revision-test.c
===================================================================
--- subversion/tests/libsvn_subr/revision-test.c (revision 26199)
+++ subversion/tests/libsvn_subr/revision-test.c (working copy)
@@ -26,8 +26,6 @@
svn_test_opts_t *opts,
apr_pool_t *pool)
{
- *msg = "test svn_parse_revision_number";
-
const char **t;
const char *failure_tests[] = {
@@ -44,6 +42,8 @@
NULL
};
+ *msg = "test svn_parse_revision_number";
+
/* These tests should succeed. */
for (t=success_tests; *t; ++t)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26195 - in trunk: . subversion/include subversion/libsvn_subr subversion/tests/libsvn_subr
Posted by Blair Zajac <bl...@orcaware.com>.
On Aug 20, 2007, at 8:54 AM, Joe Swatosh wrote:
> On 8/19/07, Blair Zajac <bl...@orcaware.com> wrote:
>> Joe Swatosh wrote:
>>> Hi Blair
>>>
>>> On 8/19/07, blair@tigris.org <bl...@tigris.org> wrote:
>
>>
>> Thanks for the patch. Applied in r26200.
>>
>> And this was with gcc 4.0.1 (C, not C++). Need to put a -std
>> command line
>> option in my build.
>>
>
> That would do it.
>
> I'm still getting my bearings. Since this isn't in my access area I
> wanted to be conservative, but should I have considered this an
> "obvious fix?"
Yes, I believe that would qualify as an obvious fix.
But I wouldn't qualify removing unused variables or even fixing
comment/code inconsistencies as obvious fixes.
Regards,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26195 - in trunk: . subversion/include subversion/libsvn_subr subversion/tests/libsvn_subr
Posted by Joe Swatosh <jo...@gmail.com>.
On 8/19/07, Blair Zajac <bl...@orcaware.com> wrote:
> Joe Swatosh wrote:
> > Hi Blair
> >
> > On 8/19/07, blair@tigris.org <bl...@tigris.org> wrote:
>
> Thanks for the patch. Applied in r26200.
>
> And this was with gcc 4.0.1 (C, not C++). Need to put a -std command line
> option in my build.
>
That would do it.
I'm still getting my bearings. Since this isn't in my access area I
wanted to be conservative, but should I have considered this an
"obvious fix?"
Thanks
--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26195 - in trunk: . subversion/include subversion/libsvn_subr
subversion/tests/libsvn_subr
Posted by Blair Zajac <bl...@orcaware.com>.
Joe Swatosh wrote:
> Hi Blair
>
> On 8/19/07, blair@tigris.org <bl...@tigris.org> wrote:
>> Author: blair
>> Date: Sun Aug 19 19:01:22 2007
>> New Revision: 26195
>>
>> Log:
>> Add a new svn_parse_revision_number() method that behaves much like
>> strtol() but returns only non-negative svn_revnum_t's.
>>
>> * subversion/include/svn_types.h
>> (svn_parse_revision_number):
>> New declaration.
>>
>
>> * subversion/tests/libsvn_subr/revision-test.c:
>> New file based off of subversion/tests/libsvn_subr/time-test.c to
>> test svn_parse_revision_number().
>>
>
>
> I needed the patche below to get it to compile (you must be using C++?).
Thanks for the patch. Applied in r26200.
And this was with gcc 4.0.1 (C, not C++). Need to put a -std command line
option in my build.
Regards,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org