You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/08/06 14:05:06 UTC
[kudu-CR] POC: Disable Sentry related tests
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14020
Change subject: POC: Disable Sentry related tests
......................................................................
POC: Disable Sentry related tests
This is done as an experiment to enable upgrading
to Hive 3.
Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
---
M src/kudu/hms/mini_hms.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/master/CMakeLists.txt
M src/kudu/sentry/CMakeLists.txt
7 files changed, 28 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/14020/1
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] POC: Disable Sentry related tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14020
to look at the new patch set (#2).
Change subject: POC: Disable Sentry related tests
......................................................................
POC: Disable Sentry related tests
This is done as an experiment to enable upgrading to Hive 3.
Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
---
M src/kudu/hms/mini_hms.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/master/CMakeLists.txt
M src/kudu/sentry/CMakeLists.txt
7 files changed, 28 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/14020/2
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] POC: Disable Sentry related tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG@7
PS1, Line 7: POC: Disable Sentry related tests
May also want to disable the mini cluster options that allow Sentry to be configured. And perhaps an equivalent change in tool_action_test.cc.
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/hms/mini_hms.cc@127
PS1, Line 127: reoved
removed
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt
File src/kudu/integration-tests/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt@93
PS1, Line 93: # NOTE: Sentry tests are disabled to allow upgrading to Hive 3.
: #ADD_KUDU_TEST(master_sentry-itest RUN_SERIAL true NUM_SHARDS 8 PROCESSORS 4)
This means we won't even compile the binary though. Could we disable these tests some other way?
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Aug 2019 17:54:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] POC: Disable Sentry related tests
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Aug 2019 18:06:49 +0000
Gerrit-HasComments: No
[kudu-CR] POC: Disable Sentry related tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt
File src/kudu/integration-tests/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt@93
PS1, Line 93: # NOTE: Sentry tests are disabled to allow upgrading to Hive 3.
: #ADD_KUDU_TEST(master_sentry-itest RUN_SERIAL true NUM_SHARDS 8 PROCESSORS 4)
> Less bit rot. It's more frustrating to fix bit rot at test compile _and_ ru
I didn't see a simple way to do this without a bunch of line changes.
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Aug 2019 19:53:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] POC: Disable Sentry related tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: POC: Disable Sentry related tests
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] POC: Disable Sentry related tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG@7
PS1, Line 7: POC: Disable Sentry related tests
> May also want to disable the mini cluster options that allow Sentry to be c
I was on the fence about this. I wanted to keep this patch as small as possible while still allowing all tests to pass. If some test comes along that tries to use Sentry and it's broken, I think that is okay and we should be aware of the breakage.
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/hms/mini_hms.cc@127
PS1, Line 127: reoved
> removed
Done
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt
File src/kudu/integration-tests/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt@93
PS1, Line 93: # NOTE: Sentry tests are disabled to allow upgrading to Hive 3.
: #ADD_KUDU_TEST(master_sentry-itest RUN_SERIAL true NUM_SHARDS 8 PROCESSORS 4)
> This means we won't even compile the binary though. Could we disable these
What's the value in compiling the binary if we never intend for it to be used/run?
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Aug 2019 18:52:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] POC: Disable Sentry related tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14020/1//COMMIT_MSG@7
PS1, Line 7: POC: Disable Sentry related tests
> I was on the fence about this. I wanted to keep this patch as small as poss
Ack
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt
File src/kudu/integration-tests/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/14020/1/src/kudu/integration-tests/CMakeLists.txt@93
PS1, Line 93: # NOTE: Sentry tests are disabled to allow upgrading to Hive 3.
: #ADD_KUDU_TEST(master_sentry-itest RUN_SERIAL true NUM_SHARDS 8 PROCESSORS 4)
> What's the value in compiling the binary if we never intend for it to be us
Less bit rot. It's more frustrating to fix bit rot at test compile _and_ runtime vs. just runtime.
That said, if it's not easy to build but not run, then don't worry about it.
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 13 Aug 2019 05:27:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] POC: Disable Sentry related tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/14020 )
Change subject: POC: Disable Sentry related tests
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] POC: Disable Sentry related tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14020
to look at the new patch set (#5).
Change subject: POC: Disable Sentry related tests
......................................................................
POC: Disable Sentry related tests
This is done as an experiment to enable upgrading to Hive 3.
Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
---
M src/kudu/hms/mini_hms.cc
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/master/CMakeLists.txt
M src/kudu/sentry/CMakeLists.txt
7 files changed, 28 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/14020/5
--
To view, visit http://gerrit.cloudera.org:8080/14020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b99b0de221f6d4acfb427f830cd3344c8d0a10b
Gerrit-Change-Number: 14020
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)