[GitHub] [incubator-superset] pl77 commented on a change in pull request #7827: Fix docker configurations and docker installation guide.

[GitBox <gi...@apache.org>]

pl77 commented on a change in pull request #7827: Fix docker configurations and docker installation guide.
URL: https://github.com/apache/incubator-superset/pull/7827#discussion_r302133617
 
 

 ##########
 File path: contrib/docker/docker-compose.yml
 ##########
 @@ -52,6 +52,7 @@ services:
       # If using production, comment development volume below
       #SUPERSET_ENV: production
       SUPERSET_ENV: development
+    user: root:root
 
 Review comment:
   Since the contrib/docker folder already has a .env file in it, it would likely be best if the user was an environmental variable declared in that file rather than hard-coded in the docker-compose file, IMHO.  
   
   For example, in the .env file add two lines:
   ```
   UID=1000
   GID=1000
   ```
   ...and then in the docker-compose file use indirect references:
   
   ```yaml
       user: ${UID}:${GID}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org