You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@infra.apache.org by "Marvin Humphrey (Created) (JIRA)" <ji...@apache.org> on 2012/04/04 00:08:24 UTC
[jira] [Created] (INFRA-4651) Add SHA sums to Github pull request
notifications
Add SHA sums to Github pull request notifications
-------------------------------------------------
Key: INFRA-4651
URL: https://issues.apache.org/jira/browse/INFRA-4651
Project: Infrastructure
Issue Type: Improvement
Security Level: public (Regular issues)
Components: Git
Reporter: Marvin Humphrey
Priority: Minor
Update our Github pull request notifications to include
the SHA sums for all commits in the patch sequence.
Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269935#comment-13269935 ]
Jukka Zitting commented on INFRA-4651:
--------------------------------------
I'm still getting an error when trying to "curl https://api.github.com/repos/apache/jackrabbit/pulls/9/commits" on git-wip-us. Works elsewhere.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Tony Stevenson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247678#comment-13247678 ]
Tony Stevenson commented on INFRA-4651:
---------------------------------------
Awesome.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Marvin Humphrey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey updated INFRA-4651:
-----------------------------------
Attachment: 0002-Use-blockquote-style-indentation.patch
0001-Add-commit-list-including-SHA-sums.patch
The first patch in this sequence appends a list of commits formatted in the
style of "git log" -- which includes the SHA sum, but also author name, author
email, date and commit message. I figure if we're going to the trouble of
getting that commit information with an extra request we might as well use it.
The second patch in the sequence is an optional stylistic patch reformatting
the email slightly. Please feel free to use or discard.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
#asfinfra IRC Bot closed INFRA-4651.
------------------------------------
Resolution: Fixed
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248190#comment-13248190 ]
Jukka Zitting commented on INFRA-4651:
--------------------------------------
Nice work, thanks! I'll give it a run later today and push to production if it works as expected.
PS. The commit hash of the head of the pull request actually implicitly references all commits leading to it (in fact the entire version history from the beginning of the project!), so the commit log is not strictly necessary here. But since we already have the code, having the information included in the notification messages is a nice extra.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245861#comment-13245861 ]
Jukka Zitting commented on INFRA-4651:
--------------------------------------
Great, thanks! I sent you our current pull request processing script in email for now as a starting point.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Marvin Humphrey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245808#comment-13245808 ]
Marvin Humphrey commented on INFRA-4651:
----------------------------------------
I'd like to provide a patch for this if I can, but right now I can't even view the
script in http://git-wip-us.apache.org/repos/infra/asfgit-admin.git because I
lack infra karma.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269591#comment-13269591 ]
Jukka Zitting commented on INFRA-4651:
--------------------------------------
Ah, sorry for dropping the ball here. The changes look good and work for me locally, but I guess the firewall settings around git-wip-us may be blocking access to https://api.github.com/.
I've now pushed the commits to git-wip-us, but until the commit log section in the pull request notifications will show up as empty until the above issue is resolved.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269594#comment-13269594 ]
#asfinfra IRC Bot commented on INFRA-4651:
------------------------------------------
<danielsh> Added api.github.com to the firewall. github.com was already there
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269952#comment-13269952 ]
#asfinfra IRC Bot commented on INFRA-4651:
------------------------------------------
<danielsh> try again please. (forgot to restart something)
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270836#comment-13270836 ]
#asfinfra IRC Bot commented on INFRA-4651:
------------------------------------------
<danielsh``> CLosing in accordance with above comment
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270830#comment-13270830 ]
Marvin Humphrey commented on INFRA-4651:
----------------------------------------
Based on this Qpid pull request, it looks like things are working:
http://s.apache.org/53h
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Marvin Humphrey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245959#comment-13245959 ]
Marvin Humphrey commented on INFRA-4651:
----------------------------------------
Thanks, Jukka. I've received the script and gotten started.
FYI, it looks like we're going to need to make an additional request, because
the pull_request payload does not contain a list of commits.
# Pull request.
curl -i https://api.github.com/repos/apache/pig/pulls/2
# Array of commits.
curl -i https://api.github.com/repos/apache/pig/pulls/2/commits
I should be able to work up a patch and submit it to JIRA for review
without further assistance.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269310#comment-13269310 ]
Marvin Humphrey commented on INFRA-4651:
----------------------------------------
I don't know whether Jukka ever applied these patches.
I have seen a couple pull requests come through recently which I would have
expected these patches to have affected, but it looked to me like nothing
had changed.
I'll ping Jukka, since I don't know if he sees these comments.
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269143#comment-13269143 ]
#asfinfra IRC Bot commented on INFRA-4651:
------------------------------------------
<danielsh> ping, ok to close this or what's left to be done here?
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-4651) Add SHA sums to Github pull request
notifications
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270849#comment-13270849 ]
Jukka Zitting commented on INFRA-4651:
--------------------------------------
Yep, looks perfect. Thanks!
> Add SHA sums to Github pull request notifications
> -------------------------------------------------
>
> Key: INFRA-4651
> URL: https://issues.apache.org/jira/browse/INFRA-4651
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Marvin Humphrey
> Priority: Minor
> Attachments: 0001-Add-commit-list-including-SHA-sums.patch, 0002-Use-blockquote-style-indentation.patch
>
>
> Update our Github pull request notifications to include
> the SHA sums for all commits in the patch sequence.
> Thread on legal-discuss: http://s.apache.org/Nhx
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira