You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2018/01/16 21:43:10 UTC

[GitHub] karlpauls opened a new pull request #3: SLING-7346: handle JSONResponse properties as json if possible.

karlpauls opened a new pull request #3: SLING-7346: handle JSONResponse properties as json if possible.
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/3
 
 
   @bhardwajrahul20 I reworked your patch a little and tried to work in some of suggestions by @kwin.
   
   The main idea is to fail fast when a property is set we can't translate into json and only allow such values (i.e., it is either of type {String, Boolean, Number, null} or the toString() is parseable as json). 
   
   Furthermore, I added some javadoc to make this explicit.
   
   @cziegeler and @rombert - what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services