You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2014/06/17 01:56:07 UTC

svn commit: r1603027 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Author: trawick
Date: Mon Jun 16 23:56:06 2014
New Revision: 1603027

URL: http://svn.apache.org/r1603027
Log:
Fix bug introduced in r1591508 which resulted in the final empty
FCGI_STDIN not being sent.  Interaction with latest uWSGI (and
probably other protocol implementations) breaks without this.

Modified:
    httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c?rev=1603027&r1=1603026&r2=1603027&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Mon Jun 16 23:56:06 2014
@@ -478,7 +478,7 @@ static apr_status_t dispatch(proxy_conn_
             if (last_stdin) {
                 pfd.reqevents = APR_POLLIN; /* Done with input data */
 
-                if (writebuflen) { /* empty AP_FCGI_STDIN not already sent? */
+                /* signal EOF (empty FCGI_STDIN) */
                     ap_fcgi_fill_in_header(&header, AP_FCGI_STDIN, request_id,
                                            0, 0);
                     ap_fcgi_header_to_array(&header, farray);
@@ -491,7 +491,6 @@ static apr_status_t dispatch(proxy_conn_
                         *err = "sending empty stdin";
                         break;
                     }
-                }
             }
         }