You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Eric Meyer (JIRA)" <ji...@apache.org> on 2006/03/01 05:12:39 UTC

[jira] Created: (COCOON-1786) BrowserUpdateTransformer can get into invalid state - must override recycle()

BrowserUpdateTransformer can get into invalid state - must override recycle()
-----------------------------------------------------------------------------

         Key: COCOON-1786
         URL: http://issues.apache.org/jira/browse/COCOON-1786
     Project: Cocoon
        Type: Bug
  Components: Blocks: Ajax  
    Versions: 2.1.8, 2.1.9-dev (current SVN)    
    Reporter: Eric Meyer
 Attachments: BrowserUpdateTransformer-recycle-patch.txt

If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.

The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (COCOON-1786) BrowserUpdateTransformer can get into invalid state - must override recycle()

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1786?page=all ]

Antonio Gallardo reassigned COCOON-1786:
----------------------------------------

    Assign To: Antonio Gallardo

> BrowserUpdateTransformer can get into invalid state - must override recycle()
> -----------------------------------------------------------------------------
>
>          Key: COCOON-1786
>          URL: http://issues.apache.org/jira/browse/COCOON-1786
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: BrowserUpdateTransformer-recycle-patch.txt
>
> If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.
> The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1786) BrowserUpdateTransformer can get into invalid state - must override recycle()

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1786?page=comments#action_12368338 ] 

Antonio Gallardo commented on COCOON-1786:
------------------------------------------

Improved Second patch applied. Would you cross check the patch and close the issue?

> BrowserUpdateTransformer can get into invalid state - must override recycle()
> -----------------------------------------------------------------------------
>
>          Key: COCOON-1786
>          URL: http://issues.apache.org/jira/browse/COCOON-1786
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: BrowserUpdateTransformer-recycle-patch.txt, BrowserUpdateTransformer-setup-recycle-patch.txt
>
> If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.
> The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (COCOON-1786) BrowserUpdateTransformer can get into invalid state - must override recycle()

Posted by "Eric Meyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1786?page=all ]
     
Eric Meyer closed COCOON-1786:
------------------------------

    Resolution: Fixed

> BrowserUpdateTransformer can get into invalid state - must override recycle()
> -----------------------------------------------------------------------------
>
>          Key: COCOON-1786
>          URL: http://issues.apache.org/jira/browse/COCOON-1786
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: BrowserUpdateTransformer-recycle-patch.txt, BrowserUpdateTransformer-setup-recycle-patch.txt
>
> If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.
> The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1786) BrowserUpdateTransformer can get into invalid state - must override recycle()

Posted by "Eric Meyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1786?page=all ]

Eric Meyer updated COCOON-1786:
-------------------------------

    Attachment: BrowserUpdateTransformer-setup-recycle-patch.txt

Upon reflection, this is more a task for the setup() method. Recycle should deal with releasing references. I've created a new patch that moves the initialization to setup(). I added nulling the reference to the Locator to the recycle() method.

> BrowserUpdateTransformer can get into invalid state - must override recycle()
> -----------------------------------------------------------------------------
>
>          Key: COCOON-1786
>          URL: http://issues.apache.org/jira/browse/COCOON-1786
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: BrowserUpdateTransformer-recycle-patch.txt, BrowserUpdateTransformer-setup-recycle-patch.txt
>
> If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.
> The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1786) BrowserUpdateTransformer can get into invalid state - must override recycle()

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1786?page=all ]

Antonio Gallardo updated COCOON-1786:
-------------------------------------


Thanks for the patch!
The patch was applied. Please cross check and close the bug.

> BrowserUpdateTransformer can get into invalid state - must override recycle()
> -----------------------------------------------------------------------------
>
>          Key: COCOON-1786
>          URL: http://issues.apache.org/jira/browse/COCOON-1786
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: BrowserUpdateTransformer-recycle-patch.txt
>
> If a form throws an exception during transformation (see https://issues.apache.org/jira/browse/COCOON-1785) then the BrowserUpdateTransformer gets into an invalid state, and futher request by any user or session that happens to use the invalid transformer receive the entire form document inside of the bu:document tag. The client side ajax javascript is then unable to process the resulting update.
> The attached patch (license granted to ASF) overrides recycle() and fixes this problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira