You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by madhawa-gunasekara <gi...@git.apache.org> on 2017/05/28 06:38:05 UTC

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

GitHub user madhawa-gunasekara opened a pull request:

    https://github.com/apache/gora/pull/104

    GORA-509: Upgrade solr library to 6.5.1

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madhawa-gunasekara/gora solr6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit b9b9be052fd3d0f1b8658b1aaa0a3df5a6b9595b
Author: madhawa <ma...@gmail.com>
Date:   2017-05-28T06:34:40Z

    GORA-509: Upgrade solr library to 6.5.1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864887
  
    --- Diff: gora-solr-5/src/test/java/org/apache/gora/solr/GoraSolr6TestDriver.java ---
    @@ -0,0 +1,72 @@
    +package org.apache.gora.solr;
    +
    +import org.apache.commons.io.FileUtils;
    +import org.apache.solr.client.solrj.embedded.JettySolrRunner;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.File;
    +
    +/**
    + * Created by madhawa on 5/28/17.
    + */
    +public class GoraSolr6TestDriver extends GoraSolrTestDriver {
    --- End diff --
    
    Please can you make sure your code is formatted using 2 space indents?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118865048
  
    --- Diff: pom.xml ---
    @@ -739,12 +739,12 @@
         <!-- Solr Dependencies -->
         <lucene-solr.version>4.10.3</lucene-solr.version>
         <solr-solrj.version>4.10.3</solr-solrj.version>
    -    <lucene-solr-5.version>5.5.1</lucene-solr-5.version>
    -    <solr-solrj-5.version>5.5.1</solr-solrj-5.version>
    -    <jetty.version>8.1.8.v20121106</jetty.version>
    +    <lucene-solr-5.version>6.5.1</lucene-solr-5.version>
    +    <solr-solrj-5.version>6.5.1</solr-solrj-5.version>
    +    <jetty.version>9.3.14.v20161028</jetty.version>
         <tika.version>1.7</tika.version>
    --- End diff --
    
    If Tika is a transient dependency made available through Solr (which I think it most definitely is), please make sure to make the update here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864847
  
    --- Diff: gora-solr-5/src/test/conf/solr6/zoo.cfg ---
    @@ -0,0 +1,17 @@
    +# The number of milliseconds of each tick
    --- End diff --
    
    License header please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/104
  
    @lewismc Are you done reviewing the PR? Shall I proceed merging this to master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by madhawa-gunasekara <gi...@git.apache.org>.
Github user madhawa-gunasekara commented on the issue:

    https://github.com/apache/gora/pull/104
  
    @lewismc 
    I have done the suggested changes. Let me know if you have any concerns.
    
    Thanks,
    Madhawa


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864858
  
    --- Diff: gora-solr-5/src/test/java/org/apache/gora/solr/GoraSolr6TestDriver.java ---
    @@ -0,0 +1,72 @@
    +package org.apache.gora.solr;
    --- End diff --
    
    License header please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/104
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/104
  
    @madhawa-gunasekara great work :) Thanks for the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864825
  
    --- Diff: gora-solr-5/src/test/conf/solr6/collection1/conf/managed-schema ---
    @@ -0,0 +1,9 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    --- End diff --
    
    License header please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/104


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by madhawa-gunasekara <gi...@git.apache.org>.
Github user madhawa-gunasekara commented on the issue:

    https://github.com/apache/gora/pull/104
  
    @djkevincr I have fixed it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864868
  
    --- Diff: gora-solr-5/src/test/java/org/apache/gora/solr/GoraSolr6TestDriver.java ---
    @@ -0,0 +1,72 @@
    +package org.apache.gora.solr;
    +
    +import org.apache.commons.io.FileUtils;
    +import org.apache.solr.client.solrj.embedded.JettySolrRunner;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.File;
    +
    +/**
    + * Created by madhawa on 5/28/17.
    --- End diff --
    
    Can you please add a more descriptive comment or else remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864990
  
    --- Diff: pom.xml ---
    @@ -739,12 +739,12 @@
         <!-- Solr Dependencies -->
         <lucene-solr.version>4.10.3</lucene-solr.version>
    --- End diff --
    
    Please remove the old lucene-solr.version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864948
  
    --- Diff: gora-solr-5/src/test/java/org/apache/gora/solr/store/TestSolr6Store.java ---
    @@ -0,0 +1,120 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.gora.solr.store;
    +
    +import org.apache.gora.examples.WebPageDataCreator;
    +import org.apache.gora.examples.generated.Employee;
    +import org.apache.gora.examples.generated.WebPage;
    +import org.apache.gora.query.Query;
    +import org.apache.gora.solr.GoraSolr6TestDriver;
    +import org.apache.gora.store.DataStore;
    +import org.apache.gora.store.DataStoreFactory;
    +import org.apache.gora.store.DataStoreTestBase;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +
    +import static junit.framework.Assert.assertNull;
    +import static org.apache.gora.examples.WebPageDataCreator.SORTED_URLS;
    +import static org.apache.gora.examples.WebPageDataCreator.URLS;
    +import static org.apache.gora.store.DataStoreTestUtil.assertNumResults;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNotNull;
    +
    +public class TestSolr6Store extends DataStoreTestBase {
    +
    +  private static final Logger LOG = LoggerFactory.getLogger(TestSolr6Store.class);
    +  private static final int NUM_KEYS = 4;
    +  
    +  static {
    +    setTestDriver(new GoraSolr6TestDriver());
    +  }
    +
    +  @Override
    +  protected DataStore<String, Employee> createEmployeeDataStore()
    +      throws IOException {
    +    SolrStore<String, Employee> store = new SolrStore<>();
    +    store.initialize(String.class, Employee.class, DataStoreFactory.createProps());
    +    return store;
    +  }
    +
    +  @Override
    +  protected DataStore<String, WebPage> createWebPageDataStore()
    +      throws IOException {
    +    SolrStore<String, WebPage> store = new SolrStore<>();
    +    store.initialize(String.class, WebPage.class, DataStoreFactory.createProps());
    +    return store;
    +  }
    +
    +  @Override
    +  public void testDeleteByQueryFields()
    +          throws Exception {
    +    Query<String, WebPage> query;
    +
    +    //test 5 - delete all with some fields
    +    WebPageDataCreator.createWebPageData(this.webPageStore);
    +
    +    query = this.webPageStore.newQuery();
    +    query.setFields("outlinks"
    +            , "parsedContent", "content");
    +
    +    assertNumResults(this.webPageStore.newQuery(), URLS.length);
    +    this.webPageStore.deleteByQuery(query);
    +
    +    this.webPageStore.flush();
    +
    +    assertNumResults(this.webPageStore.newQuery(), URLS.length);
    +
    +    //assert that data is deleted
    +    for (String SORTED_URL : SORTED_URLS) {
    +      WebPage page = this.webPageStore.get(SORTED_URL);
    +      assertNotNull(page);
    +
    +      assertNotNull(page.getUrl());
    +      assertEquals(page.getUrl().toString(), SORTED_URL);
    +      assertEquals("Map of Outlinks should have a size of '0' as the deleteByQuery "
    +              + "not only removes the data but also the data structure.", 0, page.getOutlinks().size());
    +      assertEquals(0, page.getParsedContent().size());
    +      if (page.getContent() != null) {
    +        LOG.info("url:" + page.getUrl().toString());
    --- End diff --
    
    Please use parameterized logging as follows
    ```
    LOG.info("url: {}", page.getUrl().toString());
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118865014
  
    --- Diff: pom.xml ---
    @@ -739,12 +739,12 @@
         <!-- Solr Dependencies -->
         <lucene-solr.version>4.10.3</lucene-solr.version>
         <solr-solrj.version>4.10.3</solr-solrj.version>
    -    <lucene-solr-5.version>5.5.1</lucene-solr-5.version>
    -    <solr-solrj-5.version>5.5.1</solr-solrj-5.version>
    -    <jetty.version>8.1.8.v20121106</jetty.version>
    +    <lucene-solr-5.version>6.5.1</lucene-solr-5.version>
    --- End diff --
    
    Please rename this to lucene-solr.version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/104
  
    @madhawa-gunasekara I am getting following error when I build the PR changes locally can you please check?
    
    [INFO] ------------------------------------------------------------------------
    [INFO] Building Apache Gora :: Tutorial 0.8-SNAPSHOT
    [INFO] ------------------------------------------------------------------------
    Downloading: http://repo.maven.apache.org/maven2/org/apache/solr/solr-core/${lucene-solr-5.version}/solr-core-${lucene-solr-5.version}.pom
    Downloading: http://maven.restlet.org/org/apache/solr/solr-core/${lucene-solr-5.version}/solr-core-${lucene-solr-5.version}.pom
    Downloading: http://repo.maven.apache.org/maven2/org/apache/solr/solr-solrj/${solr-solrj-5.version}/solr-solrj-${solr-solrj-5.version}.pom
    Downloading: http://maven.restlet.org/org/apache/solr/solr-solrj/${solr-solrj-5.version}/solr-solrj-${solr-solrj-5.version}.pom
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO] 
    [INFO] Apache Gora :: Tutorial ........................... FAILURE [3.183s]
    [INFO] Apache Gora :: Sources-Dist ....................... SKIPPED
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 5.005s
    [INFO] Finished at: Sun Jun 04 21:44:49 IST 2017
    [INFO] Final Memory: 25M/334M
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal on project gora-tutorial: Could not resolve dependencies for project org.apache.gora:gora-tutorial:bundle:0.8-SNAPSHOT: Failed to collect dependencies for [org.apache.gora:gora-core:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-hbase:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-jcache:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-couchdb:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-cassandra:jar:0.8-SNAPSHOT (compile), org.apache.gora:gora-solr-5:jar:0.8-SNAPSHOT (compile), org.apache.hadoop:hadoop-client:jar:2.5.2 (compile), org.apache.avro:avro:jar:1.8.1 (compile), org.apache.spark:spark-core_2.10:jar:1.4.1 (provided), org.jdom:jdom:jar:1.1.3 (compile), org.slf4j:slf4j-log4j12:jar:1.6.6 (compile), log4j:log4j:jar:1.2.16 (compile), org.ektorp:org.ektorp:jar:1.4.2 (compile)]: Failed to read artifact descriptor for org.apache.solr:solr-core:jar:${lucene-solr-5.version}: Could not transfer artifact org.apache.solr:solr-core:pom:${lucene-
 solr-5.version} from/to central (http://repo.maven.apache.org/maven2): Illegal character in path at index 63: http://repo.maven.apache.org/maven2/org/apache/solr/solr-core/${lucene-solr-5.version}/solr-core-${lucene-solr-5.version}.pom -> [Help 1]



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864812
  
    --- Diff: gora-solr-5/src/test/conf/solr6/WebPage/conf/stopwords.txt ---
    @@ -0,0 +1,14 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    --- End diff --
    
    Do we need this if there is nothing in it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864739
  
    --- Diff: gora-solr-5/src/test/conf/solr6/Employee/conf/managed-schema ---
    @@ -0,0 +1,16 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    --- End diff --
    
    Please add license header


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864835
  
    --- Diff: gora-solr-5/src/test/conf/solr6/collection1/core.properties ---
    @@ -0,0 +1 @@
    +name=collection1
    --- End diff --
    
    License header please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by madhawa-gunasekara <gi...@git.apache.org>.
Github user madhawa-gunasekara commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118874818
  
    --- Diff: gora-solr-5/src/test/conf/solr6/Employee/conf/managed-schema ---
    @@ -0,0 +1,16 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    --- End diff --
    
    Ack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864769
  
    --- Diff: gora-solr-5/src/test/conf/solr6/Employee/conf/stopwords.txt ---
    @@ -0,0 +1,14 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    --- End diff --
    
    Is this file required if there is nothing in it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #104: GORA-509: Upgrade solr library to 6.5.1

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/104#discussion_r118864789
  
    --- Diff: gora-solr-5/src/test/conf/solr6/WebPage/conf/managed-schema ---
    @@ -0,0 +1,17 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    --- End diff --
    
    Add license header please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #104: GORA-509: Upgrade solr library to 6.5.1

Posted by madhawa-gunasekara <gi...@git.apache.org>.
Github user madhawa-gunasekara commented on the issue:

    https://github.com/apache/gora/pull/104
  
    @djkevincr Thanks a lot :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---