You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 12:34:26 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #707: Fix make
dependency
yamt opened a new pull request #707: Fix make dependency
URL: https://github.com/apache/incubator-nuttx/pull/707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #707: Fix make dependency
URL: https://github.com/apache/incubator-nuttx/pull/707#discussion_r403142127
##########
File path: tools/LibTargets.mk
##########
@@ -194,7 +194,11 @@ libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT): pass1dep
staging$(DELIM)libxx$(LIBEXT): libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT)
$(Q) $(call INSTALL_LIB,$<,$@)
+ifeq ($(CONFIG_BUILD_PROTECTED),y)
Review comment:
Has this been tried CONFIG_BUILD_KERNEL? It is a similar build in many ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #707:
Fix make dependency
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #707: Fix make dependency
URL: https://github.com/apache/incubator-nuttx/pull/707#discussion_r403410901
##########
File path: tools/LibTargets.mk
##########
@@ -194,7 +194,11 @@ libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT): pass1dep
staging$(DELIM)libxx$(LIBEXT): libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT)
$(Q) $(call INSTALL_LIB,$<,$@)
+ifeq ($(CONFIG_BUILD_PROTECTED),y)
Review comment:
i haven't tested CONFIG_BUILD_KERNEL.
my understanding is this doesn't matter for CONFIG_BUILD_KERNEL as it doesn't have libapps either in USERLIBS or NUTTXLIBS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #707: Fix make dependency
URL: https://github.com/apache/incubator-nuttx/pull/707#issuecomment-608413649
while working on macOS build jobs, i saw failures which look like incomplete Make.dep. i think this patch fixes them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on pull request #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #707:
URL: https://github.com/apache/incubator-nuttx/pull/707#issuecomment-626574537
@xiaoxiang781216 @liuguo09 ok. let me know if/when you want me rebase this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #707:
URL: https://github.com/apache/incubator-nuttx/pull/707#issuecomment-626471343
@xiaoxiang781216 are you still interested in this patch? i'm getting tired to rebase this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #707:
URL: https://github.com/apache/incubator-nuttx/pull/707#issuecomment-626482777
> @xiaoxiang781216 are you still interested in this patch? i'm getting tired to rebase this.
@liuguo09 is working on this now. he can take care this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #707:
URL: https://github.com/apache/incubator-nuttx/pull/707#issuecomment-622395685
Hi @xiaoxiang781216 could you please take a look on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #707:
URL: https://github.com/apache/incubator-nuttx/pull/707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #707: Fix make dependency
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #707:
URL: https://github.com/apache/incubator-nuttx/pull/707#issuecomment-631013628
Merge through https://github.com/apache/incubator-nuttx/pull/1074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org