You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akira Ajisaka (Jira)" <ji...@apache.org> on 2019/10/07 07:00:00 UTC
[jira] [Updated] (HADOOP-16512) [hadoop-tools] Fix order of actual
and expected expression in assert statements
[ https://issues.apache.org/jira/browse/HADOOP-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akira Ajisaka updated HADOOP-16512:
-----------------------------------
Fix Version/s: 3.3.0
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed this to trunk. Thanks [~pingsutw] for the contribution.
> [hadoop-tools] Fix order of actual and expected expression in assert statements
> -------------------------------------------------------------------------------
>
> Key: HADOOP-16512
> URL: https://issues.apache.org/jira/browse/HADOOP-16512
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.2.0
> Reporter: Adam Antal
> Assignee: kevin su
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HADOOP-16512.001.patch, HADOOP-16512.002.patch
>
>
> Fix order of actual and expected expression in assert statements which gives misleading message when test case fails. Attached file has some of the places where it is placed wrongly.
> {code:java}
> [ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService) Time elapsed: 3.385 s <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the hadoop-tools project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org