You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by huafengw <gi...@git.apache.org> on 2017/03/09 10:57:35 UTC
[GitHub] incubator-gearpump pull request #169: [GEARPUMP-285] fix false alarm of shut...
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/169
[GEARPUMP-285] fix false alarm of shutting down executor time out
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 22decc4435cec306fe28c3512a930959366b985c
Author: huafengw <fv...@gmail.com>
Date: 2017-03-09T10:56:06Z
[GEARPUMP-285] fix false alarm of shutting down executor time out
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/169
I'll refactor status implementation to simple state machine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/169
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/169?src=pr&el=h1) Report
> Merging [#169](https://codecov.io/gh/apache/incubator-gearpump/pull/169?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/aebc09a8deba2c68a0664f0035d9e68e5c4219a6?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `52.63%`.
```diff
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
- Coverage 71.91% 71.62% -0.3%
=========================================
Files 191 191
Lines 6079 6080 +1
Branches 509 516 +7
=========================================
- Hits 4372 4355 -17
- Misses 1707 1725 +18
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/169?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/169?src=pr&el=footer). Last update [aebc09a...22decc4](https://codecov.io/gh/apache/incubator-gearpump/compare/aebc09a8deba2c68a0664f0035d9e68e5c4219a6...22decc4435cec306fe28c3512a930959366b985c?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/169
@manuzhang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/169
+1, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #169: [GEARPUMP-285] fix false alarm of shut...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #169: [GEARPUMP-285] fix false alarm of shutting do...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/169
Test pass: https://travis-ci.org/huafengw/incubator-gearpump/builds/209307018
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #169: [GEARPUMP-285] fix false alarm of shut...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/169#discussion_r105150887
--- Diff: core/src/main/scala/org/apache/gearpump/cluster/master/AppManager.scala ---
@@ -231,35 +231,38 @@ private[cluster] class AppManager(kvService: ActorRef, launcher: AppMasterLaunch
timeStamp: TimeStamp, error: Throwable): Unit = {
applicationRegistry.get(appId) match {
case Some(appRuntimeInfo) =>
- var updatedStatus: ApplicationRuntimeInfo = null
- LOG.info(s"Application $appId change to ${newStatus.toString} at $timeStamp")
- newStatus match {
- case ApplicationStatus.ACTIVE =>
- updatedStatus = appRuntimeInfo.onAppMasterActivated(timeStamp)
- sender ! AppMasterActivated(appId)
- case succeeded@ApplicationStatus.SUCCEEDED =>
- killAppMaster(appId, appRuntimeInfo.worker)
- updatedStatus = appRuntimeInfo.onFinalStatus(timeStamp, succeeded)
- appResultListeners.getOrElse(appId, List.empty).foreach{ client =>
- client ! ApplicationSucceeded(appId)
- }
- case failed@ApplicationStatus.FAILED =>
- killAppMaster(appId, appRuntimeInfo.worker)
- updatedStatus = appRuntimeInfo.onFinalStatus(timeStamp, failed)
- appResultListeners.getOrElse(appId, List.empty).foreach{ client =>
- client ! ApplicationFailed(appId, error)
- }
- case terminated@ApplicationStatus.TERMINATED =>
- updatedStatus = appRuntimeInfo.onFinalStatus(timeStamp, terminated)
- case status =>
- LOG.error(s"App $appId should not change it's status to $status")
- }
+ // A dead application should not be able to update status
+ if (!appRuntimeInfo.status.isInstanceOf[ApplicationTerminalStatus]) {
--- End diff --
Do we want to update status if not changed ? Can there be other "false alarm"s ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---