[GitHub] [rocketmq] ferrirW commented on a diff in pull request #6680: [ISSUE #6679]SubscriptionData may not be updated when the client's system time is rolled back

["ferrirW (via GitHub)" <gi...@apache.org>]

ferrirW commented on code in PR #6680:
URL: https://github.com/apache/rocketmq/pull/6680#discussion_r1184807789


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java:
##########
@@ -57,7 +57,8 @@ public void messageQueueChanged(String topic, Set<MessageQueue> mqAll, Set<Messa
          * Fix: inconsistency subscription may lead to consumer miss messages.
          */
         SubscriptionData subscriptionData = this.subscriptionInner.get(topic);
-        long newVersion = System.currentTimeMillis();

Review Comment:
   Maybe it could be nanoseconds



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org