You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2018/06/05 20:40:11 UTC

[GitHub] keith-turner commented on a change in pull request #1004: FLUO-1000 OracleServer race conditions

keith-turner commented on a change in pull request #1004: FLUO-1000 OracleServer race conditions
URL: https://github.com/apache/fluo/pull/1004#discussion_r193214544
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/oracle/OracleServer.java
 ##########
 @@ -318,6 +324,10 @@ public synchronized void start() throws Exception {
     curatorFramework.getConnectionStateListenable().addListener(cnxnListener);
     curatorFramework.start();
 
+    while (!curatorFramework.getState().equals(CuratorFrameworkState.STARTED)) {
 
 Review comment:
   I don't think this is needed because curator immediately changes the state in `start()`.  After start returns, the state will be `STARTED`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services