You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "aalmiray (via GitHub)" <gi...@apache.org> on 2023/04/28 15:13:01 UTC
[GitHub] [commons-jexl] aalmiray opened a new pull request, #177: JEXL-296: Add full Java module descriptor
aalmiray opened a new pull request, #177:
URL: https://github.com/apache/commons-jexl/pull/177
Fix for https://issues.apache.org/jira/browse/JEXL-396
**Notes**
- release must be performed with Java 9+ to trigger the profiel that generates the module descriptor
- package `org.apache.commons.jexl3.internal` and subpackages are not exported
- module name is set to `org.apache.commons.jexl3` which may trigger warnings due to the use of a number at the end. The module system thinks this is a versioned module and freaks out (no crashes though). Consider perhaps using `org.apache.commons.jexl` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-jexl] aalmiray commented on pull request #177: JEXL-296: Add full Java module descriptor
Posted by "aalmiray (via GitHub)" <gi...@apache.org>.
aalmiray commented on PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#issuecomment-1527720696
Bytecode compatibility
```
$ jarviz bytecode show --file target/commons-jexl3-3.3.1-SNAPSHOT.jar
subject: commons-jexl3-3.3.1-SNAPSHOT.jar
Unversioned classes. Bytecode version: 52 (Java 8) total: 321
Versioned classes 9. Bytecode version: 53 (Java 9) total: 1
```
Resolved module descriptor
```
$ jarviz module descriptor --file target/commons-jexl3-3.3.1-SNAPSHOT.jar
subject: commons-jexl3-3.3.1-SNAPSHOT.jar
name: org.apache.commons.jexl3
version: 3.3.1-SNAPSHOT
open: false
automatic: false
exports:
org.apache.commons.jexl3
org.apache.commons.jexl3.annotations
org.apache.commons.jexl3.introspection
org.apache.commons.jexl3.parser
org.apache.commons.jexl3.scripting
requires:
commons.logging
java.base mandated
java.desktop
java.scripting
provides:
javax.script.ScriptEngineFactory with org.apache.commons.jexl3.scripting.JexlScriptEngineFactory
contains:
org.apache.commons.jexl3.internal
org.apache.commons.jexl3.internal.introspection
```
Manifest
```
$ jarviz manifest show --file target/commons-jexl3-3.3.1-SNAPSHOT.jar
subject: commons-jexl3-3.3.1-SNAPSHOT.jar
Manifest-Version: 1.0
Created-By: Apache Maven Bundle Plugin 5.1.8
Build-Jdk-Spec: 17
Implementation-Title: Apache Commons JEXL
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache
Implementation-Version: 3.3.1-SNAPSHOT
Specification-Title: Apache Commons JEXL
Specification-Vendor: The Apache Software Foundation
Specification-Version: 3.3.1-SNAPSHOT
X-Compile-Source-JDK: 1.8
X-Compile-Target-JDK: 1.8
Bundle-Description: JEXL is a library intended to facilitate the impleme
ntation of scripting features in applications and frameworks wri
tten in Java.
Bundle-DocURL: https://commons.apache.org/proper/commons-jexl/
Bundle-License: https://www.apache.org/licenses/LICENSE-2.0.txt
Bundle-ManifestVersion: 2
Bundle-Name: Apache Commons JEXL
Bundle-SymbolicName: org.apache.commons.commons-jexl3
Bundle-Vendor: The Apache Software Foundation
Bundle-Version: 3.3.1.SNAPSHOT
Export-Package: org.apache.commons.jexl3;version="3.3.1.SNAPSHOT",org.ap
ache.commons.jexl3.annotations;version="3.3.1.SNAPSHOT",org.apache.comm
ons.jexl3.internal;version="3.3.1.SNAPSHOT",org.apache.commons.jexl3.in
ternal.introspection;version="3.3.1.SNAPSHOT",org.apache.commons.jexl3.
introspection;version="3.3.1.SNAPSHOT",org.apache.commons.jexl3.parser;
version="3.3.1.SNAPSHOT",org.apache.commons.jexl3.scripting;version="3.
3.1.SNAPSHOT"
Import-Package: javax.script,org.apache.commons.logging
Include-Resource: META-INF/services/javax.script.ScriptEngineFactory=src
/main/resources/META-INF/services/javax.script.ScriptEngineFactory,META
-INF/NOTICE.txt=NOTICE.txt,META-INF/LICENSE.txt=LICENSE.txt
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Tool: Bnd-6.4.0.202211291949
Multi-Release: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-jexl] aalmiray commented on pull request #177: JEXL-396: Add full Java module descriptor
Posted by "aalmiray (via GitHub)" <gi...@apache.org>.
aalmiray commented on PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#issuecomment-1527889541
Thanks! 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-jexl] henrib commented on a diff in pull request #177: JEXL-396: Add full Java module descriptor
Posted by "henrib (via GitHub)" <gi...@apache.org>.
henrib commented on code in PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#discussion_r1180595036
##########
pom.xml:
##########
@@ -519,4 +519,48 @@
<name>Dmitri Blinov</name>
</contributor>
</contributors>
+
+ <profiles>
+ <profile>
+ <id>java-module</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.moditect</groupId>
+ <artifactId>moditect-maven-plugin</artifactId>
+ <version>1.0.0.RC3</version>
+ <executions>
+ <execution>
+ <id>add-module-infos</id>
+ <phase>package</phase>
+ <goals>
+ <goal>add-module-info</goal>
+ </goals>
+ <configuration>
+ <jvmVersion>9</jvmVersion>
+ <overwriteExistingFiles>true</overwriteExistingFiles>
+ <module>
+ <moduleInfo>
+ <name>${commons.module.name}</name>
+ <exports>
+ !org.apache.commons.jexl3.internal*;
Review Comment:
I think we should not export the parser package either. Its not documented, mostly generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-jexl] aalmiray commented on a diff in pull request #177: JEXL-396: Add full Java module descriptor
Posted by "aalmiray (via GitHub)" <gi...@apache.org>.
aalmiray commented on code in PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#discussion_r1180659678
##########
pom.xml:
##########
@@ -519,4 +519,48 @@
<name>Dmitri Blinov</name>
</contributor>
</contributors>
+
+ <profiles>
+ <profile>
+ <id>java-module</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.moditect</groupId>
+ <artifactId>moditect-maven-plugin</artifactId>
+ <version>1.0.0.RC3</version>
+ <executions>
+ <execution>
+ <id>add-module-infos</id>
+ <phase>package</phase>
+ <goals>
+ <goal>add-module-info</goal>
+ </goals>
+ <configuration>
+ <jvmVersion>9</jvmVersion>
+ <overwriteExistingFiles>true</overwriteExistingFiles>
+ <module>
+ <moduleInfo>
+ <name>${commons.module.name}</name>
+ <exports>
+ !org.apache.commons.jexl3.internal*;
Review Comment:
Updated as requested. force pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JEXL-396: Add full Java module descriptor [commons-jexl]
Posted by "harikrishnaganji98 (via GitHub)" <gi...@apache.org>.
harikrishnaganji98 commented on PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#issuecomment-1753160095
@henrib For which ASF project do you want to file a ticket?
What should I select here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-jexl] henrib merged pull request #177: JEXL-396: Add full Java module descriptor
Posted by "henrib (via GitHub)" <gi...@apache.org>.
henrib merged PR #177:
URL: https://github.com/apache/commons-jexl/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JEXL-396: Add full Java module descriptor [commons-jexl]
Posted by "harikrishnaganji98 (via GitHub)" <gi...@apache.org>.
harikrishnaganji98 commented on PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#issuecomment-1752554479
@henrib I have an issue with JEXL.
Where can I raise it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JEXL-396: Add full Java module descriptor [commons-jexl]
Posted by "henrib (via GitHub)" <gi...@apache.org>.
henrib commented on PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#issuecomment-1752999917
> @henrib I have an issue with JEXL.
> Where can I raise it?
Not here for sure :-) Have a look at https://commons.apache.org/proper/commons-jexl/issue-tracking.html .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org