You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by qu...@apache.org on 2005/04/03 10:59:29 UTC
svn commit: r159902 - spamassassin/trunk/Makefile.PL
Author: quinlan
Date: Sun Apr 3 00:59:28 2005
New Revision: 159902
URL: http://svn.apache.org/viewcvs?view=rev&rev=159902
Log:
bug 3382: Makefile does not rebuild objects when c file changed
Modified:
spamassassin/trunk/Makefile.PL
Modified: spamassassin/trunk/Makefile.PL
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/Makefile.PL?view=diff&r1=159901&r2=159902
==============================================================================
--- spamassassin/trunk/Makefile.PL (original)
+++ spamassassin/trunk/Makefile.PL Sun Apr 3 00:59:28 2005
@@ -1053,7 +1053,7 @@
$(PERL) -MFile::Spec -MFile::Copy \
-e "copy(q{$(SOURCE)}, q{$(TARGET)});"
-spamc/libspamc.so: $(SPAMC_MAKEFILE) $(LIBSPAMC_SRC)
+spamc/libspamc.so: $(SPAMC_MAKEFILE) $(LIBSPAMC_SRC)
$(MAKE_SPAMC) $@
spamd/libspamc.so: spamc/libspamc.so
@@ -1065,7 +1065,7 @@
spamd/libsslspamc.so: spamc/libsslspamc.so
$(MAKE_SPAMC_OLD)
-spamc/spamc$(EXE_EXT): $(SPAMC_MAKEFILE) $(SPAMC_SRC)
+spamc/spamc$(EXE_EXT): $(SPAMC_MAKEFILE) $(SPAMC_SRC) $(LIBSPAMC_SRC)
$(MAKE_SPAMC) $@
spamd/spamc$(EXE_EXT): spamc/spamc$(EXE_EXT)
Re: svn commit: r159902 - spamassassin/trunk/Makefile.PL
Posted by Daniel Quinlan <qu...@pathname.com>.
Duncan Findlay <du...@debian.org> writes:
> Shouldn't that be
> spamc/spamc$(EXE_EXT): $(SPAMC_MAKEFILE) $(SPAMC_SRC) spamc/libspamc.so
>
> That way it builds when the .so changes rather than the
> source. Technicalities I guess, but more resilient to future changes.
I made it the same as spamc/Makefile.
I'm not really sure why we even the same Makefile code in two places,
but if you want to change both to their benefit, go ahead. :-)
Daniel
--
Daniel Quinlan
http://www.pathname.com/~quinlan/
Re: svn commit: r159902 - spamassassin/trunk/Makefile.PL
Posted by Duncan Findlay <du...@debian.org>.
On Sun, Apr 03, 2005 at 08:59:29AM -0000, quinlan@apache.org wrote:
> Author: quinlan
> Date: Sun Apr 3 00:59:28 2005
> New Revision: 159902
>
> URL: http://svn.apache.org/viewcvs?view=rev&rev=159902
> Log:
> bug 3382: Makefile does not rebuild objects when c file changed
....
> -spamc/libspamc.so: $(SPAMC_MAKEFILE) $(LIBSPAMC_SRC)
> +spamc/libspamc.so: $(SPAMC_MAKEFILE) $(LIBSPAMC_SRC)
> $(MAKE_SPAMC) $@
>
> spamd/libspamc.so: spamc/libspamc.so
> @@ -1065,7 +1065,7 @@
> spamd/libsslspamc.so: spamc/libsslspamc.so
> $(MAKE_SPAMC_OLD)
>
> -spamc/spamc$(EXE_EXT): $(SPAMC_MAKEFILE) $(SPAMC_SRC)
> +spamc/spamc$(EXE_EXT): $(SPAMC_MAKEFILE) $(SPAMC_SRC) $(LIBSPAMC_SRC)
> $(MAKE_SPAMC) $@
Shouldn't that be
spamc/spamc$(EXE_EXT): $(SPAMC_MAKEFILE) $(SPAMC_SRC) spamc/libspamc.so
That way it builds when the .so changes rather than the
source. Technicalities I guess, but more resilient to future changes.
--
Duncan Findlay