You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/28 12:15:02 UTC
[GitHub] [spark] dohongdayi opened a new pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
dohongdayi opened a new pull request #34127:
URL: https://github.com/apache/spark/pull/34127
What changes were proposed in this pull request?
Migrate UseStatement to v2 command framework
Why are the changes needed?
Migrate to the standard V2 framework
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937759897
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48446/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r721861588
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
shall we have a single place to resolve `UnresolvedDBObjectName`? Currently it's resolved in L34 in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937923533
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48460/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929834830
no need to worry about K8S failure. As long as all the tests pass or `All checks have passed`, you should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-932016493
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929729696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937921923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937442324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934426089
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937504898
**[Test build #143938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143938/testReport)** for PR 34127 at commit [`7477193`](https://github.com/apache/spark/commit/74771931f6509364d061c921ccd81154ec50a7fc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934633018
**[Test build #143855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143855/testReport)** for PR 34127 at commit [`a451466`](https://github.com/apache/spark/commit/a451466b146c81492316b98a62fefc698bfcae52).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931946610
**[Test build #143783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143783/testReport)** for PR 34127 at commit [`e578d1c`](https://github.com/apache/spark/commit/e578d1c9491c615308f92302cd9300a81cc1b203).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937985571
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143967/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929837708
@huaxingao Ok, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939414962
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144059/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939412778
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48537/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939426594
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48539/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939139555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144034/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938546050
**[Test build #144021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144021/testReport)** for PR 34127 at commit [`4617c19`](https://github.com/apache/spark/commit/4617c19e48b306431f5ae2a0f7417803d4942321).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938618848
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48498/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case UnresolvedDBObjectName(CatalogAndIdentifier(catalog, identifier), _) =>`
` ResolvedDBObjectName(catalog, identifier.namespace :+ identifier.name())`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), isNamespace) if isNamespace =>`
` ResolvedDBObjectName(catalog, name)`
`case UnresolvedDBObjectName(CatalogAndIdentifier(catalog, identifier), _) =>`
` ResolvedDBObjectName(catalog, identifier.namespace :+ identifier.name())`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, I have given a one more try, please take a look
Thanks
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, I have given a one more try, please take a look
Thanks
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
I didn't see any other way to resolve `UnresolvedDBObjectName` separately, without failing [test case of `USE NAMESPACE`](https://github.com/apache/spark/blob/aa393cdafff5c9f20d41133631a4efcdee3ccdc7/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala#L1356)
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
I didn't see any way to resolve `UnresolvedDBObjectName` separately, without failing [test case of `USE NAMESPACE`](https://github.com/apache/spark/blob/aa393cdafff5c9f20d41133631a4efcdee3ccdc7/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala#L1356)
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
I didn't see any way to resolve `UnresolvedDBObjectName` separately, without failing [test case of `USE NAMESPACE`](https://github.com/apache/spark/blob/aa393cdafff5c9f20d41133631a4efcdee3ccdc7/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala#L1354-L1356)
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, could you please advise?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939139088
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144033/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937589373
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939696970
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939227076
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144041/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937697721
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48446/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929832000
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929143158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929849757
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143690/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931352946
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48279/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931558442
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143768/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931969826
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937463441
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937442324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939417244
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48539/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937478068
**[Test build #143924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143924/testReport)** for PR 34127 at commit [`a451466`](https://github.com/apache/spark/commit/a451466b146c81492316b98a62fefc698bfcae52).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938858222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144032/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r724839663
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
For `USE NAMESPACE xxx`, can we add a new `SetNamespaceCommand` which does not use `UnresolvedDBObjectName`? We can follow `SetCatalogCommand` in https://github.com/apache/spark/pull/34096
For `USE xxx`, I think `UnresolvedDBObjectName` should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937878864
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48460/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939409656
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48537/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939424046
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48539/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937588938
**[Test build #143924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143924/testReport)** for PR 34127 at commit [`a451466`](https://github.com/apache/spark/commit/a451466b146c81492316b98a62fefc698bfcae52).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930951039
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>
ResolvedDBObjectName(catalog, name)
......
case Use(ResolvedDBObjectName(catalog, ns)) =>
val namespace = if (ns.nonEmpty) Some(ns) else None
SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)
`
But it will change the behavior of `USE NAMESPACE ...` to keep it in line with `CREATE NAMESPACE ...`, which is NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934475053
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939426594
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48539/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929359228
@cloud-fan, could you review this please ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929732162
**[Test build #143690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143690/testReport)** for PR 34127 at commit [`c527355`](https://github.com/apache/spark/commit/c5273559b467d7bd1a78b9cb48a60513c5d195c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929143158
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-932026995
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937489640
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48428/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937985571
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143967/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938021198
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48477/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938854684
**[Test build #144032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144032/testReport)** for PR 34127 at commit [`da8b9d0`](https://github.com/apache/spark/commit/da8b9d07d4330e5c07543d13b0c3d4d46cb2d3fb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938598365
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48498/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939226275
**[Test build #144041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144041/testReport)** for PR 34127 at commit [`e74482c`](https://github.com/apache/spark/commit/e74482c90e4790baade71d694ebef777777592b7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class IndexAlreadyExistsException(message: String, cause: Option[Throwable] = None)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938722078
**[Test build #144021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144021/testReport)** for PR 34127 at commit [`4617c19`](https://github.com/apache/spark/commit/4617c19e48b306431f5ae2a0f7417803d4942321).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class CreateTempFunction(`
* `case class CreateFunction(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r725154558
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1022,3 +1022,13 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the USE command.
+ */
+case class Use(name: LogicalPlan) extends UnaryCommand {
Review comment:
There already is one `SetCatalogAndNamespace` in line 627, I'm gonna reapply with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938887065
**[Test build #144034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144034/testReport)** for PR 34127 at commit [`f89eb5c`](https://github.com/apache/spark/commit/f89eb5cd7133d46cba3190a5358f85cfac42076f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But it will change the behavior of `USE NAMESPACE ...` to keep it in line with `CREATE NAMESPACE ...`, which is NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937632607
**[Test build #143963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143963/testReport)** for PR 34127 at commit [`1529439`](https://github.com/apache/spark/commit/15294396129cf5bcdc951e604f7ef1933726072a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937811491
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143946/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929732162
**[Test build #143690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143690/testReport)** for PR 34127 at commit [`c527355`](https://github.com/apache/spark/commit/c5273559b467d7bd1a78b9cb48a60513c5d195c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r721861978
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3565,11 +3565,13 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
/**
- * Create a [[UseStatement]] logical plan.
+ * Create a [[Use]] logical plan.
*/
override def visitUse(ctx: UseContext): LogicalPlan = withOrigin(ctx) {
val nameParts = visitMultipartIdentifier(ctx.multipartIdentifier)
- UseStatement(ctx.NAMESPACE != null, nameParts)
+ Use(UnresolvedDBObjectName(
+ nameParts,
+ ctx.NAMESPACE != null))
Review comment:
```suggestion
Use(UnresolvedDBObjectName(nameParts, ctx.NAMESPACE != null))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931154306
**[Test build #143754 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143754/testReport)** for PR 34127 at commit [`b078177`](https://github.com/apache/spark/commit/b0781773ecaa2c7626de16bbefa069ddf9e6a9c3).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public final class TableIndex `
* `class IndexAlreadyExistsException(indexName: String, table: Identifier)`
* `class NoSuchIndexException(indexName: String)`
* `case class AsOfJoin(`
* `case class ShowCurrentNamespaceCommand() extends LeafRunnableCommand `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r723977636
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
I didn't see any way to resolve `UnresolvedDBObjectName` separately, without failing [test case of `USE NAMESPACE`](https://github.com/apache/spark/blob/aa393cdafff5c9f20d41133631a4efcdee3ccdc7/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala#L1354-L1356)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929729696
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929787369
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722231345
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, Yeah, but I didn't see any other way to keep `Use` working as the same as `UseStatement` with `ResolvedDBObjectName`, should we create new JIRA for this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934634321
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143855/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934387268
**[Test build #143855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143855/testReport)** for PR 34127 at commit [`a451466`](https://github.com/apache/spark/commit/a451466b146c81492316b98a62fefc698bfcae52).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939138724
**[Test build #144034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144034/testReport)** for PR 34127 at commit [`f89eb5c`](https://github.com/apache/spark/commit/f89eb5cd7133d46cba3190a5358f85cfac42076f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938878634
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r725154558
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1022,3 +1022,13 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the USE command.
+ */
+case class Use(name: LogicalPlan) extends UnaryCommand {
Review comment:
There already is a `SetCatalogAndNamespace` in line 627, I'm gonna reapply with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938990618
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938993594
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937420568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938019877
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938051299
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48477/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939139088
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144033/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939139555
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144034/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939203682
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48518/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938618848
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48498/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937679969
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143938/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937764952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48452/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930096749
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937972955
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938019877
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929849757
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143690/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r723818264
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, I have given a one more try, please take a look
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931421234
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48279/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931319797
**[Test build #143768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143768/testReport)** for PR 34127 at commit [`af634e1`](https://github.com/apache/spark/commit/af634e122088f0636c062ffcf9f986c383fa21e2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931405047
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48279/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929143158
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931946610
**[Test build #143783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143783/testReport)** for PR 34127 at commit [`e578d1c`](https://github.com/apache/spark/commit/e578d1c9491c615308f92302cd9300a81cc1b203).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929793429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937503538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937470108
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48425/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931319797
**[Test build #143768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143768/testReport)** for PR 34127 at commit [`af634e1`](https://github.com/apache/spark/commit/af634e122088f0636c062ffcf9f986c383fa21e2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937420568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case UnresolvedDBObjectName(CatalogAndIdentifier(catalog, identifier), _) =>`
` ResolvedDBObjectName(catalog, identifier.namespace :+ identifier.name())`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937470108
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48425/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937438314
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48425/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937921923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937867148
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937867148
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34127:
URL: https://github.com/apache/spark/pull/34127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939461514
**[Test build #144061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144061/testReport)** for PR 34127 at commit [`596e50e`](https://github.com/apache/spark/commit/596e50ed7554ee5e01ff605177aa1abd1e09f3da).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938858179
**[Test build #144032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144032/testReport)** for PR 34127 at commit [`da8b9d0`](https://github.com/apache/spark/commit/da8b9d07d4330e5c07543d13b0c3d4d46cb2d3fb).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class SetCatalogAndNamespace(child: LogicalPlan) extends UnaryCommand `
* `case class SetNamespaceCommand(namespace: Seq[String]) extends LeafRunnableCommand `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r725154558
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1022,3 +1022,13 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the USE command.
+ */
+case class Use(name: LogicalPlan) extends UnaryCommand {
Review comment:
It seems like there already is one `SetCatalogAndNamespace` in line 627, I'm gonna reapply with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937632607
**[Test build #143963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143963/testReport)** for PR 34127 at commit [`1529439`](https://github.com/apache/spark/commit/15294396129cf5bcdc951e604f7ef1933726072a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938879087
**[Test build #144033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144033/testReport)** for PR 34127 at commit [`f55e112`](https://github.com/apache/spark/commit/f55e112fd0891bde9830a128fa4441038d697124).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi edited a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi edited a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
I don't think the K8S IT failure is related with this PR, it should be caused by K8S was unstable or lack of resource, so I'm trying to start the test build again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929732162
**[Test build #143690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143690/testReport)** for PR 34127 at commit [`c527355`](https://github.com/apache/spark/commit/c5273559b467d7bd1a78b9cb48a60513c5d195c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will change the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which is NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-932145698
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143783/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>
ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>
val namespace = if (ns.nonEmpty) Some(ns) else None
SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)
`
But it will change the behavior of `USE NAMESPACE ...` to keep it in line with `CREATE NAMESPACE ...`, which is NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi edited a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi edited a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929143158
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929793429
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929793429
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r723977636
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
I didn't see any way to resolve `UnresolvedDBObjectName` separately, without failing [test case of `USE NAMESPACE`](https://github.com/apache/spark/blob/aa393cdafff5c9f20d41133631a4efcdee3ccdc7/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala#L1356)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939054284
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939192145
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48518/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939054266
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938957669
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48509/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939402216
**[Test build #144059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144059/testReport)** for PR 34127 at commit [`4210828`](https://github.com/apache/spark/commit/42108289f645fa7b75dfd3a5a6777888329ec932).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938748950
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144021/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938879087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938546050
**[Test build #144021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144021/testReport)** for PR 34127 at commit [`4617c19`](https://github.com/apache/spark/commit/4617c19e48b306431f5ae2a0f7417803d4942321).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939050274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939413313
**[Test build #144061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144061/testReport)** for PR 34127 at commit [`596e50e`](https://github.com/apache/spark/commit/596e50ed7554ee5e01ff605177aa1abd1e09f3da).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939412778
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48537/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938063376
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48477/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938573105
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48498/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939414854
**[Test build #144059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144059/testReport)** for PR 34127 at commit [`4210828`](https://github.com/apache/spark/commit/42108289f645fa7b75dfd3a5a6777888329ec932).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r724229751
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, should we redesign `ResolvedDBObjectName` for `Use` ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
I think the K8S IT failure was caused by K8S was unstable or lack of resource, so I'm trying to start the test build again.
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930951158
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930804433
**[Test build #143754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143754/testReport)** for PR 34127 at commit [`b078177`](https://github.com/apache/spark/commit/b0781773ecaa2c7626de16bbefa069ddf9e6a9c3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930096749
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi edited a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi edited a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
I don't think the K8S IT failure is related with this PR, it might be caused by K8S was unstable or lack of resource, so I'm trying to start the test build again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937983978
**[Test build #143967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143967/testReport)** for PR 34127 at commit [`036597c`](https://github.com/apache/spark/commit/036597c0bf16954f03dd6f7c2d1af41962b9d243).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` new_class = type(`
* `case class SetCatalogCommand(catalogName: String) extends LeafRunnableCommand `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937923501
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48460/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937759897
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48446/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937503538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937420568
**[Test build #143907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143907/testReport)** for PR 34127 at commit [`0b8af71`](https://github.com/apache/spark/commit/0b8af71aa639a12befd7d0da4e424ef91937e3b3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937832885
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937542174
**[Test build #143946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143946/testReport)** for PR 34127 at commit [`8d20ab5`](https://github.com/apache/spark/commit/8d20ab56bb37b27756f9db97cdd2fd890f3583b4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937440462
**[Test build #143907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143907/testReport)** for PR 34127 at commit [`0b8af71`](https://github.com/apache/spark/commit/0b8af71aa639a12befd7d0da4e424ef91937e3b3).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930855901
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931558442
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143768/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-932026995
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48295/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934634321
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143855/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937690813
**[Test build #143967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143967/testReport)** for PR 34127 at commit [`036597c`](https://github.com/apache/spark/commit/036597c0bf16954f03dd6f7c2d1af41962b9d243).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939050274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939461780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144061/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938005218
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48471/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r724840109
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1022,3 +1022,13 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the USE command.
+ */
+case class Use(name: LogicalPlan) extends UnaryCommand {
Review comment:
```suggestion
case class SetCatalogAndNamespace(namespace: LogicalPlan) extends UnaryCommand {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939405716
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48537/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r724229751
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, should we redesign `ResolvedDBObjectName` for `Use`? Or create new JIRA for having a single place to resolve `UnresolvedDBObjectName`?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939227076
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144041/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r725800604
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -106,7 +106,8 @@ singleTableSchema
statement
: query #statementDefault
| ctes? dmlStatementNoWith #dmlStatement
- | USE NAMESPACE? multipartIdentifier #use
+ | USE multipartIdentifier #use
+ | USE NAMESPACE multipartIdentifier #useNamespace
Review comment:
some databases like DB2 support `SET SCHEMA xxx`, maybe we can change this parser rule to `SET | USE NAMESPACE ...` in the future, to be more lenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937679429
**[Test build #143938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143938/testReport)** for PR 34127 at commit [`7477193`](https://github.com/apache/spark/commit/74771931f6509364d061c921ccd81154ec50a7fc).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939045486
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48510/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938063376
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48477/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938858222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144032/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939138351
**[Test build #144033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144033/testReport)** for PR 34127 at commit [`f55e112`](https://github.com/apache/spark/commit/f55e112fd0891bde9830a128fa4441038d697124).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929359228
@cloud-fan, could you review this please ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937675746
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48443/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937690813
**[Test build #143967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143967/testReport)** for PR 34127 at commit [`036597c`](https://github.com/apache/spark/commit/036597c0bf16954f03dd6f7c2d1af41962b9d243).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937730331
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48446/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929732162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937458984
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48425/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937913226
**[Test build #143963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143963/testReport)** for PR 34127 at commit [`1529439`](https://github.com/apache/spark/commit/15294396129cf5bcdc951e604f7ef1933726072a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934475053
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939183268
**[Test build #144041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144041/testReport)** for PR 34127 at commit [`e74482c`](https://github.com/apache/spark/commit/e74482c90e4790baade71d694ebef777777592b7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938748950
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144021/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-932136829
**[Test build #143783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143783/testReport)** for PR 34127 at commit [`e578d1c`](https://github.com/apache/spark/commit/e578d1c9491c615308f92302cd9300a81cc1b203).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), isNamespace) if isNamespace =>`
` ResolvedDBObjectName(catalog, name)`
`case UnresolvedDBObjectName(CatalogAndIdentifier(catalog, identifier), _) =>`
` ResolvedDBObjectName(catalog, identifier.namespace :+ identifier.name())`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will CHANGE the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937778455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937504898
**[Test build #143938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143938/testReport)** for PR 34127 at commit [`7477193`](https://github.com/apache/spark/commit/74771931f6509364d061c921ccd81154ec50a7fc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r724229751
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, could you please advise?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But as I said, it will change the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which will be NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937589373
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937764911
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48452/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939414962
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144059/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939054284
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939183268
**[Test build #144041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144041/testReport)** for PR 34127 at commit [`e74482c`](https://github.com/apache/spark/commit/e74482c90e4790baade71d694ebef777777592b7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722276156
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3565,11 +3565,13 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
/**
- * Create a [[UseStatement]] logical plan.
+ * Create a [[Use]] logical plan.
*/
override def visitUse(ctx: UseContext): LogicalPlan = withOrigin(ctx) {
val nameParts = visitMultipartIdentifier(ctx.multipartIdentifier)
- UseStatement(ctx.NAMESPACE != null, nameParts)
+ Use(UnresolvedDBObjectName(
+ nameParts,
+ ctx.NAMESPACE != null))
Review comment:
Right, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937923533
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48460/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931156559
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143754/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930804433
**[Test build #143754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143754/testReport)** for PR 34127 at commit [`b078177`](https://github.com/apache/spark/commit/b0781773ecaa2c7626de16bbefa069ddf9e6a9c3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931156559
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143754/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938854684
**[Test build #144032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144032/testReport)** for PR 34127 at commit [`da8b9d0`](https://github.com/apache/spark/commit/da8b9d07d4330e5c07543d13b0c3d4d46cb2d3fb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r724840109
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -1022,3 +1022,13 @@ case class UncacheTable(
override def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)
}
+
+/**
+ * The logical plan of the USE command.
+ */
+case class Use(name: LogicalPlan) extends UnaryCommand {
Review comment:
```suggestion
case class Use(namespace: LogicalPlan) extends UnaryCommand {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939461780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144061/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929878733
@cloud-fan, could you review this please ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi edited a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi edited a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
I don't think the K8S IT failure is related with this PR, it should be caused by K8S cluster was unstable or lack of resource, so I'm trying to start the test build again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929849021
**[Test build #143690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143690/testReport)** for PR 34127 at commit [`c527355`](https://github.com/apache/spark/commit/c5273559b467d7bd1a78b9cb48a60513c5d195c6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929766776
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48206/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi edited a comment on pull request #34127: [SPARK-36849][SQL][WIP] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi edited a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-929831765
I think the K8S IT failure was caused by K8S was unstable or lack of resource, so I'm trying to start the test build again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-930951158
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r723977636
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -31,6 +31,15 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
import org.apache.spark.sql.connector.catalog.CatalogV2Util._
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
I didn't see any other way to resolve `UnresolvedDBObjectName` separately, without failing [test case of `USE NAMESPACE`](https://github.com/apache/spark/blob/aa393cdafff5c9f20d41133631a4efcdee3ccdc7/sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala#L1356)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937478068
**[Test build #143924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143924/testReport)** for PR 34127 at commit [`a451466`](https://github.com/apache/spark/commit/a451466b146c81492316b98a62fefc698bfcae52).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934387268
**[Test build #143855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143855/testReport)** for PR 34127 at commit [`a451466`](https://github.com/apache/spark/commit/a451466b146c81492316b98a62fefc698bfcae52).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>
ResolvedDBObjectName(catalog, name)
......
case Use(ResolvedDBObjectName(catalog, ns)) =>
val namespace = if (ns.nonEmpty) Some(ns) else None
SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)
`
But it will change the behavior of `USE NAMESPACE ...` to keep it in line with `CREATE NAMESPACE ...`, which is NO different with `USE ...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937501946
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48430/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939203682
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48518/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939402216
**[Test build #144059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144059/testReport)** for PR 34127 at commit [`4210828`](https://github.com/apache/spark/commit/42108289f645fa7b75dfd3a5a6777888329ec932).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939200967
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48518/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937675746
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48443/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722231345
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, Yeah, but I didn't see an other way to keep USE working as the same as UseStatement with ResolvedDBObjectName, should we create new JIRA for this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-938878634
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939044563
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48509/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937811491
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143946/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-939413313
**[Test build #144061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144061/testReport)** for PR 34127 at commit [`596e50e`](https://github.com/apache/spark/commit/596e50ed7554ee5e01ff605177aa1abd1e09f3da).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722231345
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, Yeah, but I didn't see an other way to keep `Use` working as the same as `UseStatement` with `ResolvedDBObjectName`, should we create new JIRA for this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937679969
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143938/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r723818264
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
@cloud-fan, I have given a one more try, please take a look
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937717636
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48452/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937622413
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48443/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937542174
**[Test build #143946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143946/testReport)** for PR 34127 at commit [`8d20ab5`](https://github.com/apache/spark/commit/8d20ab56bb37b27756f9db97cdd2fd890f3583b4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dohongdayi commented on a change in pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
dohongdayi commented on a change in pull request #34127:
URL: https://github.com/apache/spark/pull/34127#discussion_r722263212
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala
##########
@@ -80,8 +80,8 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
writeOptions = c.writeOptions,
orCreate = c.orCreate)
- case UseStatement(isNamespaceSet, nameParts) =>
- if (isNamespaceSet) {
+ case Use(UnresolvedDBObjectName(nameParts, isNamespace)) =>
Review comment:
One way to resolve `UnresolvedDBObjectName` in single place, is
`case UnresolvedDBObjectName(CatalogAndNamespace(catalog, name), _) =>`
` ResolvedDBObjectName(catalog, name)`
`case Use(ResolvedDBObjectName(catalog, ns)) =>`
` val namespace = if (ns.nonEmpty) Some(ns) else None`
` SetCatalogAndNamespace(catalogManager, Some(catalog.name()), namespace)`
But it will change the behavior of `USE NAMESPACE ...` to be in line with `CREATE NAMESPACE ...`, which is NO different with `USE ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937666930
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48443/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-934460772
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48368/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937420568
**[Test build #143907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143907/testReport)** for PR 34127 at commit [`0b8af71`](https://github.com/apache/spark/commit/0b8af71aa639a12befd7d0da4e424ef91937e3b3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937442324
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143907/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937468735
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48430/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-937442324
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143907/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931421234
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48279/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-932145698
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143783/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34127: [SPARK-36849][SQL] Migrate UseStatement to v2 command framework
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34127:
URL: https://github.com/apache/spark/pull/34127#issuecomment-931554540
**[Test build #143768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143768/testReport)** for PR 34127 at commit [`af634e1`](https://github.com/apache/spark/commit/af634e122088f0636c062ffcf9f986c383fa21e2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org