[GitHub] [apisix] membphis commented on a change in pull request #2622: fix bug of attempt to compare number with string

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #2622:
URL: https://github.com/apache/apisix/pull/2622#discussion_r517353340



##########
File path: apisix/plugins/prometheus/exporter.lua
##########
@@ -178,8 +178,13 @@ local function set_modify_index(key, items, items_ver, global_max_index)
     local max_idx = 0
     if items_ver and items then
         for _, item in ipairs(items) do
-            if type(item) == "table" and item.modifiedIndex > max_idx then
-                max_idx = item.modifiedIndex
+            if type(item) == "table" then

Review comment:
       that is the wrong way.
   
   please take a look at the `2.0` or master branch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org