You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Steve Loughran (Created) (JIRA)" <ji...@apache.org> on 2012/02/17 18:39:59 UTC

[jira] [Created] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Add a test to formalise the current state transitions of the yarn lifecycle
---------------------------------------------------------------------------

                 Key: MAPREDUCE-3877
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
             Project: Hadoop Map/Reduce
          Issue Type: Test
          Components: mrv2
    Affects Versions: 0.24.0
            Reporter: Steve Loughran
            Assignee: Steve Loughran
            Priority: Minor


Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 

It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210535#comment-13210535 ] 

Robert Joseph Evans commented on MAPREDUCE-3877:
------------------------------------------------

I like the concept of the patch. One minor issue with it though In BreakableService.java inside private int convert(STATE state) the switch has a default state that returns 0.  I would prefer to see the default throw an exception. default means that for some reason STATE was modified and we want to detect that instead of silently counting extra NOINITED.
 


                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated MAPREDUCE-3877:
--------------------------------------

    Attachment: MAPREDUCE-3877.patch

test and reusable service and assertions
                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210970#comment-13210970 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1764 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1764/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245918)

     Result = ABORTED
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245918
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210929#comment-13210929 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #560 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/560/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245914)
MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245913)

     Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245914
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245913
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211338#comment-13211338 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #173 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/173/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245914)
MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245913)

     Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245914
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245913
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210941#comment-13210941 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #1753 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1753/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245918)

     Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245918
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210938#comment-13210938 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1827 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1827/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245918)

     Result = FAILURE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245918
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210932#comment-13210932 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Common-0.23-Commit #574 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/574/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245914)
MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245913)

     Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245914
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245913
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211353#comment-13211353 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #201 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/201/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245914)
MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245913)

     Result = FAILURE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245914
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245913
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated MAPREDUCE-3877:
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.2
                   0.24.0
           Status: Resolved  (was: Patch Available)
    
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210934#comment-13210934 ] 

Steve Loughran commented on MAPREDUCE-3877:
-------------------------------------------

I'm going to note that these tests show flaws in the current lifecycle that need to be addressed. Specifically

# as the ensureState checks are performed at the end of all subclasses start/stop/init operations, they always perform their operations regardless of the current state. This allows you to enter these states more than once
# if anything goes wrong during init and start the system is left in an indeterminate state
# you can't stop without starting, yet init can acquire resources that need to be explicitly released -and which you may want to release without starting the service.
                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211333#comment-13211333 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #960 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/960/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245918)

     Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245918
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211349#comment-13211349 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #995 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/995/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245918)

     Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245918
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Arun C Murthy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-3877:
-------------------------------------

    Affects Version/s:     (was: 0.24.0)
        Fix Version/s:     (was: 0.24.0)
    
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210965#comment-13210965 ] 

Hudson commented on MAPREDUCE-3877:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #576 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/576/])
    MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245914)
MAPREDUCE-3877 Add a test to formalise the current state transitions of the yarn lifecycle (Revision 1245913)

     Result = ABORTED
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245914
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/BreakableService.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/ServiceAssert.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/service/TestServiceLifecycle.java

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1245913
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt

                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.2
>
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated MAPREDUCE-3877:
--------------------------------------

    Status: Patch Available  (was: In Progress)

tests only; tests pass; nothing to fear except a formalisation of the implict service lifecycle semantics
                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210439#comment-13210439 ] 

Hadoop QA commented on MAPREDUCE-3877:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515001/MAPREDUCE-3877.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1888//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1888//console

This message is automatically generated.
                
> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: MAPREDUCE-3877.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work started] (MAPREDUCE-3877) Add a test to formalise the current state transitions of the yarn lifecycle

Posted by "Steve Loughran (Work started) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MAPREDUCE-3877 started by Steve Loughran.

> Add a test to formalise the current state transitions of the yarn lifecycle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3877
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3877
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: mrv2
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add a test service that counts the number of times it's state methods are called; and can be set to raise an exception on any such entry. Use it to show what the current lifecycle state model is, so that unintentional regressions can be detected. 
> It will also act as a foundation for intentional changes to that lifecycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira