You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (Created) (JIRA)" <ji...@apache.org> on 2012/01/13 19:30:40 UTC
[jira] [Created] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
[Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
---------------------------------------------------------------------------------------
Key: HBASE-5195
URL: https://issues.apache.org/jira/browse/HBASE-5195
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0, 0.94.0
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212160#comment-13212160 ]
Hudson commented on HBASE-5195:
-------------------------------
Integrated in HBase-0.92-security #91 (See [https://builds.apache.org/job/HBase-0.92-security/91/])
HBASE-5195 [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get (Revision 1245765)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210706#comment-13210706 ]
Hudson commented on HBASE-5195:
-------------------------------
Integrated in HBase-0.92 #288 (See [https://builds.apache.org/job/HBase-0.92/288/])
HBASE-5195 [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get (Revision 1245765)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Andrew Purtell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-5195:
----------------------------------
Fix Version/s: (was: 0.92.0)
0.92.1
The patch resolves this issue in a test cluster, but I'm going to add a unit test. Marking for 0.92.1. Change it if you feel strongly it should be in 0.92.0.
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-5195.
--------------------------
Resolution: Fixed
Committed to 0.92. Already in trunk.
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211142#comment-13211142 ]
Hudson commented on HBASE-5195:
-------------------------------
Integrated in HBase-TRUNK #2665 (See [https://builds.apache.org/job/HBase-TRUNK/2665/])
HBASE-5195 [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get -- SECOND HALF OF THIS COMMIT (Revision 1245773)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5195:
------------------------------
Fix Version/s: 0.94.0
0.92.0
Hadoop Flags: Reviewed
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210828#comment-13210828 ]
Hudson commented on HBASE-5195:
-------------------------------
Integrated in HBase-TRUNK-security #114 (See [https://builds.apache.org/job/HBase-TRUNK-security/114/])
HBASE-5195 [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get -- SECOND HALF OF THIS COMMIT (Revision 1245773)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210569#comment-13210569 ]
Andrew Purtell commented on HBASE-5195:
---------------------------------------
+1 for including in 0.92.1
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210590#comment-13210590 ]
stack commented on HBASE-5195:
------------------------------
oops. Its not already in trunk. But my commit to get it into trunk was messy. I did it in three commits; first a bungled commit that added half which I then reverted. Then added back. Here is where I made my mess:
{code}
------------------------------------------------------------------------
r1245773 | stack | 2012-02-17 13:34:46 -0800 (Fri, 17 Feb 2012) | 1 line
HBASE-5195 [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get -- SECOND HALF OF THIS COMMIT
------------------------------------------------------------------------
r1245768 | stack | 2012-02-17 13:26:23 -0800 (Fri, 17 Feb 2012) | 1 line
HBASE-5279 NPE in Master after upgrading to 0.92.0 -- REVERT OVERCOMMIT TO HREGION
------------------------------------------------------------------------
r1245767 | stack | 2012-02-17 13:24:21 -0800 (Fri, 17 Feb 2012) | 1 line
HBASE-5279 NPE in Master after upgrading to 0.92.0
{code}
r1245767 adds
{code}
@@ -3684,6 +3682,8 @@
}
}
+ Scan scan = new Scan(get);
+
RegionScanner scanner = null;
try {
scanner = getScanner(scan);
{code}
... but not...
{code}
@@ -3673,8 +3673,6 @@
*/
private List<KeyValue> get(Get get, boolean withCoprocessor)
throws IOException {
- Scan scan = new Scan(get);
-
List<KeyValue> results = new ArrayList<KeyValue>();
// pre-get CP hook
{code}
... then r1245768 reverts it because above failed to go in.
Then r1245773 is fixup.
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210565#comment-13210565 ]
stack commented on HBASE-5195:
------------------------------
This looks like a pretty important fix. Should it be more than major priority? Should it go into 0.92.1?
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.94.0, 0.92.1
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186021#comment-13186021 ]
Zhihong Yu commented on HBASE-5195:
-----------------------------------
+1 on patch.
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5195) [Coprocessors] preGet hook does not
allow overriding or wrapping filter on incoming Get
Posted by "Andrew Purtell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-5195:
----------------------------------
Attachment: HBASE-5195.patch
Trying out the attached patch.
> [Coprocessors] preGet hook does not allow overriding or wrapping filter on incoming Get
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-5195
> URL: https://issues.apache.org/jira/browse/HBASE-5195
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: HBASE-5195.patch
>
>
> Without the ability to wrap the internal Scan on the Get, we can't override (or protect, in the case of access control) Gets as we can Scans. The result is inconsistent behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira