You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/06/22 12:16:52 UTC
[GitHub] storm pull request #2172: STORM-2369 [storm-redis] Use binary type for State...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2172
STORM-2369 [storm-redis] Use binary type for State management
* introduce new command interface and relevant containers
* new command interface will contain both binary and string commands in near future
* change RedisKeyValue to use byte[] for State key and value management instead of String
* get rid of Base64 encode/decode on RedisEncoder, and also SafeEncoder.encode() in Jedis internal
* users can select either Redis single server or Redis Cluster by passing JedisPoolConfig or JedisClusterConfig
* implement binary based KV state iterator
* Provide a tool to migrate old base64 state to the new binary state
* migration tool is placed to storm-redis-examples
* the module is easy to create uber jar hence easy to run the class
* document how to build and use migration tool
This patch is equivalent to #1950. Please note that there're some other changes for fixing checkstyle. I didn't address all of them, but my patch exceeded the limit so I ended up to fix some in this patch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2369
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2172
----
commit 9ab3df5ed8e6fdeb6017c1f3f7f182ed51872246
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-02-21T06:35:58Z
STORM-2369 [storm-redis] Use binary type for State management
* introduce new command interface and relevant containers
* new command interface will contain both binary and string commands in near future
* change RedisKeyValue to use byte[] for State key and value management instead of String
* get rid of Base64 encode/decode on RedisEncoder, and also SafeEncoder.encode() in Jedis internal
* users can select either Redis single server or Redis Cluster by passing JedisPoolConfig or JedisClusterConfig
* implement binary based KV state iterator
* Provide a tool to migrate old base64 state to the new binary state
* migration tool is placed to storm-redis-examples
* the module is easy to create uber jar hence easy to run the class
* document how to build and use migration tool
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2172: STORM-2369 [storm-redis] Use binary type for State manage...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2172
Filed an issue for versioning state: https://issues.apache.org/jira/browse/STORM-2605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2172: STORM-2369 [storm-redis] Use binary type for State manage...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2172
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2172: STORM-2369 [storm-redis] Use binary type for State manage...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2172
Just update the PR to make equivalent to #1950
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2172: STORM-2369 [storm-redis] Use binary type for State...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---