You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/28 07:21:43 UTC
[GitHub] [skywalking] codecov-io edited a comment on issue #4570: [Inventory
Design Change] Remove endpoint register and endpoint inventory
codecov-io edited a comment on issue #4570: [Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
> Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9c62e4f52dbfa42ac3fbcc94ce0518dc89cbc165&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `5.58%`.
[](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4570 +/- ##
==========================================
+ Coverage 26.14% 26.22% +0.07%
==========================================
Files 1257 1253 -4
Lines 29265 28991 -274
Branches 4027 3951 -76
==========================================
- Hits 7651 7602 -49
+ Misses 20906 20699 -207
+ Partials 708 690 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...commands/executor/ServiceResetCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvU2VydmljZVJlc2V0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `12.50% <0.00%> (+1.38%)` | :arrow_up: |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `72.41% <ø> (+1.44%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `60.71% <ø> (+5.87%)` | :arrow_up: |
| [...walking/apm/agent/core/context/trace/ExitSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FeGl0U3Bhbi5qYXZh) | `55.55% <ø> (+1.98%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...walking/apm/agent/core/context/trace/NoopSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Ob29wU3Bhbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `69.56% <ø> (+14.30%)` | :arrow_up: |
| [...g/apm/agent/core/dictionary/DictionaryManager.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `100.00% <ø> (ø)` | |
| [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [06d30f1...06d30f1](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services