[GitHub] [incubator-superset] DiggidyDave opened a new pull request #8626: slightly decouple sql_json, queries, and results http endpoints from …

[GitBox <gi...@apache.org>]

DiggidyDave opened a new pull request #8626: slightly decouple sql_json, queries, and results http endpoints from …
URL: https://github.com/apache/incubator-superset/pull/8626
 
 
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [X] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Some of the views and view logic (http request handlers, template rendering, response construction, etc) is hyper-coupled to the business logic. In our case, we need to setup alternate endpoints with different internal auth, routes, etc to use the `sql_json`, `queries`, and `results` endpoints from `views.core.Superset`.  I think these should be more thoroughly decoupled (ie, views just doing view stuff, and calling into a completely separate library for business logic) but that is a lot more than I can chew off right now, so this tiny change is simply breaking those three http request handlers off so we other functions can call into the business logic from different endpoints.
   
   Choose one##** BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org